fix: refactoring the logic of adding the subscriptionData#209
Open
juliabrzvtex wants to merge 2 commits into
Open
fix: refactoring the logic of adding the subscriptionData#209juliabrzvtex wants to merge 2 commits into
juliabrzvtex wants to merge 2 commits into
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
The current logic for adding subscription items to the cart had a bug in calculating the itemIndex when a promotion added a gift to the cart. Reordering the items array invalidated the previous index calculation, resulting in the subscription data being associated with the wrong item.
How should this be manually tested?
To check for the bug, add an item with a promotional offer to the cart and then try adding an item with a subscription. When checking the subscriptionData field, no information will be provided regarding the latter item.
Fix tested in this workspace: https://testvtex--clubsoftysb2c.myvtex.com/jabon-barra-elite-humectante-pack-3-un/p
Type of changes