fix: make eager prop work again for Image and skip lazy load if prop isEager #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR ensures that images explicitly marked for eager loading are not overridden by the render-runtime’s lazy-loading behavior, so the Image block’s eager-loading configuration works as intended.
Changes:
- Introduces an
isEagercheck inMaybeLazyImagebased onimageProps.loading === 'eager'. - Skips applying both native lazy-loading (
loading="lazy") and thelazysizeslogic when the image is eager, while preserving the existing preload (data-vtex-preload) behavior.
vmourac-vtex
requested changes
Jan 28, 2026
Contributor
vmourac-vtex
left a comment
vmourac-vtex
left a comment
There was a problem hiding this comment.
Hi @Giov7 thanks for submitting your PR!
Your change makes sense and seems in line with loading behavior in components like ProductImage, InfoCard, etc.
@iago1501 @vsseixaso what do you think?
Regardless, I would ask you to:
- Modify the
CHANGELOGfile with your proposed change - Add tests to validate your changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem on the Image block which doesn't allow eager loading. That's happening because of vtex render runtime non-handling the image prop correctly.
How to test it? *
I tested this behaviour here: https://www.whirlpool.it/?workspace=testkg65