fix: per-package publish workflows and v* tag format#40
Merged
Conversation
…ws and v* tag format DK webhook processor rejects tags that aren't pure semver (e.g. `ads-react-v0.5.1` returned HTTP 500). Switch to `v*` tag format and split into two npm-publish-v1 pipelines (one per package via contextPath). Each workflow reads its version from package.json instead of parsing the tag name. - Add publish-core.yml and publish-react.yml (replace publish-npm.yml) - Update deployment.yaml: two npm-publish-v1 pipelines + v* tag regex - Bump ads-react to 0.5.2 to sync with ads-core - Update README release docs to reflect new tag format and workflow split Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ads-react-v0.5.1returned HTTP 500 ("Invalid source refs/tags/ads-react-v0.5.1"). Tag format is nowv0.5.2.publish-core.ymlandpublish-react.ymlreplace the singlepublish-npm.yml. Each reads the version from its ownpackage.json(no more tag parsing).npm-publish-v1pipelines (one per package viacontextPath), tag regex updated to^v[0-9]+\.[0-9]+\.[0-9]+(-[A-Za-z0-9.-]+)?$.Release flow after merging
git checkout main && git pull git tag v0.5.2 git push origin v0.5.2DK triggers both pipelines → CodeArtifact → GitHub Actions auto-triggered → npmjs.
NPM Trusted Publishers (one-time setup if not done yet)
@vtex/ads-reactneedspublish-react.ymladded on npmjs.com (previously onlypublish-npm.ymlwas registered)@vtex/ads-coreneedspublish-core.ymlupdated ifpublish-npm.ymlwas registeredTest plan
v0.5.2— confirm DK processes it with HTTP 200 (not 500)publish-core.yml,publish-react.yml)@vtex/ads-core@0.5.2and@vtex/ads-react@0.5.2published to npm🤖 Generated with Claude Code