fix: typesVersions paths + ads-docs build order#43
Open
brenonovelli wants to merge 1 commit into
Open
Conversation
…o ads-docs typesVersions pointed to ./dist/clients/ but the actual output directory is ./dist/esm/clients/ — TypeDoc and older TypeScript resolvers couldn't find the declaration files for @vtex/ads-core/adServer and @vtex/ads-core/search subpaths. Adding @vtex/ads-core and @vtex/ads-react as devDependencies to ads-docs so Turbo enforces build order and ads-docs never starts before types are generated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the pre-existing CI failure in
ads-docs:build.Root causes
1. Wrong
typesVersionspaths in@vtex/ads-coretypesVersionspointed to./dist/clients/adServer/index.d.tsbut tsup outputs declarations to./dist/esm/clients/adServer/index.d.ts. TypeDoc (used byads-docs) and TypeScript resolvers that fall back totypesVersionscouldn't find the.d.tsfor the/adServerand/searchsubpaths.2. Turbo build ordering
ads-docsdidn't list@vtex/ads-coreor@vtex/ads-reactas dependencies, so Turbo could startads-docs:buildin parallel with the packages on cold cache — before their types were generated.Changes
packages/core/package.json:./dist/clients/→./dist/esm/clients/intypesVersionspackages/ads-docs/package.json: add@vtex/ads-coreand@vtex/ads-reactasdevDependenciesso Turbo waits for them before starting the docs build🤖 Generated with Claude Code