fix: remove packageManager field to unblock DK pnpm publish#44
Merged
Conversation
…pm via CodeArtifact When DK runs `pnpm publish --registry <CodeArtifact-URL>`, pnpm sets that registry globally. The `"packageManager": "pnpm@10.14.0"` field triggers corepack/pnpm to try to download @pnpm/exe from the configured registry (CodeArtifact) — which doesn't have it and returns 401. Removing the field keeps pnpm as the package manager (pnpm-workspace.yaml still enforces it) without triggering the version enforcement download. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… DK CI pnpm v10 blocks build scripts by default. Without the packageManager field, the DK pod uses its globally installed pnpm v10 which exits with code 1 when build scripts are ignored — causing the node-install step to fail. Explicitly allowlist the packages that legitimately need build scripts. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Instead of removing the packageManager field (which turbo requires to resolve workspaces), disable pnpm's version enforcement via .npmrc. This prevents pnpm from trying to download @pnpm/exe from the CodeArtifact registry when DK runs pnpm publish --registry <CodeArtifact-URL>. Also keeps pnpm.onlyBuiltDependencies to avoid ERR_PNPM_IGNORED_BUILDS with pnpm v10's default build script blocking. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
When DK runs
pnpm publish --registry <CodeArtifact-URL>, it sets that registry globally for the pnpm invocation. The"packageManager": "pnpm@10.14.0"field triggers corepack/pnpm to try to download@pnpm/exe(orpnpm) from the currently configured registry — which is CodeArtifact. CodeArtifact doesn't have these packages and returns 401.Fix
Remove
"packageManager": "pnpm@10.14.0"from rootpackage.json.pnpm-workspace.yamlstill enforces workspace resolutionAfter merging
Bump both packages to
0.5.4(or re-trigger with same0.5.3if CodeArtifact hasn't stored it) and push a newv0.5.Xtag.🤖 Generated with Claude Code