Skip to content

fix(runtime-vapor): remove teleport with insertion parent#14718

Merged
edison1105 merged 1 commit intominorfrom
edison/fix/14717
Apr 13, 2026
Merged

fix(runtime-vapor): remove teleport with insertion parent#14718
edison1105 merged 1 commit intominorfrom
edison/fix/14717

Conversation

@edison1105
Copy link
Copy Markdown
Member

@edison1105 edison1105 commented Apr 13, 2026

close #14717

Summary by CodeRabbit

  • Bug Fixes

    • Fixed teleport component cleanup to properly remove the component from the DOM when conditionally rendered and hidden.
  • Tests

    • Added test coverage for teleport component behavior during conditional rendering.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d802724-04df-4300-9384-b203c41c1db7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch edison/fix/14717

Comment @coderabbitai help to get the list of available commands and usage tips.

@edison1105 edison1105 linked an issue Apr 13, 2026 that may be closed by this pull request
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 13, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14718
npm i https://pkg.pr.new/@vue/compiler-core@14718
yarn add https://pkg.pr.new/@vue/compiler-core@14718.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14718
npm i https://pkg.pr.new/@vue/compiler-dom@14718
yarn add https://pkg.pr.new/@vue/compiler-dom@14718.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14718
npm i https://pkg.pr.new/@vue/compiler-sfc@14718
yarn add https://pkg.pr.new/@vue/compiler-sfc@14718.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14718
npm i https://pkg.pr.new/@vue/compiler-ssr@14718
yarn add https://pkg.pr.new/@vue/compiler-ssr@14718.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14718
npm i https://pkg.pr.new/@vue/compiler-vapor@14718
yarn add https://pkg.pr.new/@vue/compiler-vapor@14718.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14718
npm i https://pkg.pr.new/@vue/reactivity@14718
yarn add https://pkg.pr.new/@vue/reactivity@14718.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14718
npm i https://pkg.pr.new/@vue/runtime-core@14718
yarn add https://pkg.pr.new/@vue/runtime-core@14718.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14718
npm i https://pkg.pr.new/@vue/runtime-dom@14718
yarn add https://pkg.pr.new/@vue/runtime-dom@14718.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14718
npm i https://pkg.pr.new/@vue/runtime-vapor@14718
yarn add https://pkg.pr.new/@vue/runtime-vapor@14718.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14718
npm i https://pkg.pr.new/@vue/server-renderer@14718
yarn add https://pkg.pr.new/@vue/server-renderer@14718.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14718
npm i https://pkg.pr.new/@vue/shared@14718
yarn add https://pkg.pr.new/@vue/shared@14718.tgz

vue

pnpm add https://pkg.pr.new/vue@14718
npm i https://pkg.pr.new/vue@14718
yarn add https://pkg.pr.new/vue@14718.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14718
npm i https://pkg.pr.new/@vue/compat@14718
yarn add https://pkg.pr.new/@vue/compat@14718.tgz

commit: d6b9696

@github-actions
Copy link
Copy Markdown

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 86.4 kB 30.3 kB 26.6 kB
runtime-dom.global.prod.js 112 kB 42.3 kB 37.9 kB
vue.global.prod.js 172 kB 62.1 kB 55.3 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 51.1 kB 19.9 kB 18.2 kB
createApp 60.2 kB 23.3 kB 21.2 kB
createApp + vaporInteropPlugin 88.5 kB (+16 B) 32.5 kB (+10 B) 29.4 kB (+12 B)
createVaporApp 29.1 kB (+16 B) 11.3 kB (+12 B) 10.3 kB (+4 B)
createSSRApp 64.7 kB 25 kB 22.7 kB
createVaporSSRApp 34.8 kB (+16 B) 13.3 kB (+7 B) 12.2 kB (+6 B)
defineCustomElement 66.7 kB 25.2 kB 22.9 kB
defineVaporCustomElement 36.3 kB (+16 B) 13.4 kB (+6 B) 12.3 kB (+2 B)
overall 75.2 kB 28.6 kB 26 kB

@edison1105 edison1105 added the scope: vapor related to vapor mode label Apr 13, 2026
@edison1105 edison1105 merged commit 5f38cb5 into minor Apr 13, 2026
17 checks passed
@edison1105 edison1105 deleted the edison/fix/14717 branch April 13, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vapor] Unable to remove Teleport nested within a regular element

1 participant