Add Recursive Directory search options, and simplify shuffle behavior#248
Open
Jadrie wants to merge 9 commits intovzhd1701:masterfrom
Open
Add Recursive Directory search options, and simplify shuffle behavior#248Jadrie wants to merge 9 commits intovzhd1701:masterfrom
Jadrie wants to merge 9 commits intovzhd1701:masterfrom
Conversation
Adjust Shuffle to include subdirectories, and resolve an issue with previous file looping back to the first file rather than the last.
Correct Case
Corrected subdirectory travel looping by adding an original_dir that references the parent dir from the first file.
Swapped Video Navigation to a class, so the index persists on initial load of a video
rewired video switching to use navigator class
This reverts commit 0b45867.
also removed shuffle_video command, as shuffle is handled on initial video load rather than every new video.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to be able to include subdirectories when I set a folder to repeat, so added some extra logic with a VideoNavigator class- this now grabs the full file list of the directory and all subdirectories, and if shuffle is requested, will shuffle the list once at that time.
This change to the shuffle behavior prevents repeats from happening as easily, as we're not doing a shuffle every time a new video is loaded, which could move the same video to the top of the sibling list multiple times in a row.