Skip to content

refactor(capture): extract assembly validation#611

Merged
w1ne merged 1 commit into
developfrom
codex/assembly-capture-validation
Jul 9, 2026
Merged

refactor(capture): extract assembly validation#611
w1ne merged 1 commit into
developfrom
codex/assembly-capture-validation

Conversation

@w1ne

@w1ne w1ne commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Extract assembly-specific session validation and solved-joint normalization into src/modeling/capture/assemblyCaptureValidation.ts
  • Keep CaptureSession as the owner of register/createShape, record IDs, and metadata.paramRefs
  • Add direct validation/orchestration tests for exact errors, malformed-joint behavior, no record append on failed validation, and paramRefs preservation

Verification

  • npm test -- tests/unit/capture/assemblyCaptureValidation.test.ts tests/unit/capture/assemblyFeatureRecords.test.ts tests/unit/assemblies/assemblyCapture.test.ts tests/unit/assemblies/subAssemblyComposition.test.ts src/modeling/mates/validator.test.ts tests/integration/lowering/sceneAssemblyModel.test.ts tests/integration/lowering/coloredPosedAssembly.test.ts tests/unit/kernel/architectureBoundary.test.ts tests/integration/lowering/sceneToCompoundUnion.test.ts tests/integration/lowering/solvedAssemblyReactive.test.ts
  • npm run typecheck
  • npx eslint src/modeling/capture/captureSession.ts src/modeling/capture/assemblyFeatureRecords.ts src/modeling/capture/assemblyCaptureValidation.ts tests/unit/capture/assemblyCaptureValidation.test.ts tests/unit/capture/assemblyFeatureRecords.test.ts
  • npx depcruise --config .dependency-cruiser.cjs --output-type json src/modeling/capture/assemblyCaptureValidation.ts src/modeling/capture/assemblyFeatureRecords.ts

Review

  • Architecture reviewer: no blockers
  • Behavior reviewer: no blockers

No docs or generated assets changed.

@w1ne w1ne merged commit b3e35ec into develop Jul 9, 2026
13 checks passed
@w1ne w1ne deleted the codex/assembly-capture-validation branch July 9, 2026 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant