Skip to content

refactor(capture): extract shape operation records#612

Merged
w1ne merged 1 commit into
developfrom
codex/shape-operation-capture
Jul 10, 2026
Merged

refactor(capture): extract shape operation records#612
w1ne merged 1 commit into
developfrom
codex/shape-operation-capture

Conversation

@w1ne

@w1ne w1ne commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • extract shape operation record builders and session validation from CaptureSession
  • move proxy face-ref helper import to the focused shape-operation module while preserving the CaptureSession re-export
  • add selector/spec regression coverage for Query DSL, face wrappers, draft metadata, variable edge groups, and session ownership errors

Verification

  • npm test -- tests/unit/capture/shapeOperationFeatureRecords.test.ts tests/unit/capture/proxy.fillet.test.ts tests/unit/capture/proxy.shell.test.ts src/modeling/capture/proxy.test.ts tests/unit/capture/shapeBendCapture.test.ts tests/unit/capture/sketch.test.ts tests/integration/lowering/queryLowererIntegration.test.ts tests/integration/backends/occt/variableFilletFaceWrapper.test.ts tests/unit/backends/occt/draft.test.ts
  • npm run typecheck
  • npx eslint src/modeling/capture/captureSession.ts src/modeling/capture/proxy.ts src/modeling/capture/shapeOperationFeatureRecords.ts src/modeling/capture/shapeOperationCaptureValidation.ts tests/unit/capture/shapeOperationFeatureRecords.test.ts
  • filtered depcruise on shapeOperation* modules: 0 touched violations
  • git diff --check

Subagent reviews: architecture/dependency and behavior-regression reviewers reported no findings.

@w1ne w1ne merged commit cfe66a8 into develop Jul 10, 2026
13 checks passed
@w1ne w1ne deleted the codex/shape-operation-capture branch July 10, 2026 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant