Clone response in Lookup Race Response algorithm#1811
Merged
yoshisatoyanagisawa merged 1 commit intow3c:mainfrom Dec 12, 2025
Merged
Clone response in Lookup Race Response algorithm#1811yoshisatoyanagisawa merged 1 commit intow3c:mainfrom
yoshisatoyanagisawa merged 1 commit intow3c:mainfrom
Conversation
The "Lookup Race Response" algorithm returned a response from the race response map directly. This could lead to issues where a response body is consumed more than once, as a Response object's body cannot be reused across multiple fetch operations. This change modifies the algorithm to return a clone of the response, aligning with the Fetch specification's standard practice for handling responses that may be used by multiple consumers. This ensures that each fetch handler receives a distinct, readable stream. See also: https://fetch.spec.whatwg.org/#concept-response-clone
Collaborator
Author
|
@sisidovski Will you take a look? |
Collaborator
Author
|
@monica-ch Will you review this? |
github-actions bot
added a commit
that referenced
this pull request
Dec 12, 2025
SHA: 3ff30ad Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Dec 12, 2025
SHA: 3ff30ad Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
Jan 23, 2026
SHA: 3ff30ad Reason: push, by yoshisatoyanagisawa Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Lookup Race Response" algorithm returned a response from the race response map directly. This could lead to issues where a response body is consumed more than once, as a Response object's body cannot be reused across multiple fetch operations.
This change modifies the algorithm to return a clone of the response, aligning with the Fetch specification's standard practice for handling responses that may be used by multiple consumers. This ensures that each fetch handler receives a distinct, readable stream.
See also: https://fetch.spec.whatwg.org/#concept-response-clone
Preview | Diff