Editorial: "Update Service Worker Extended Events Set" minor fix#1813
Merged
yoshisatoyanagisawa merged 1 commit intow3c:mainfrom Jan 26, 2026
Merged
Editorial: "Update Service Worker Extended Events Set" minor fix#1813yoshisatoyanagisawa merged 1 commit intow3c:mainfrom
yoshisatoyanagisawa merged 1 commit intow3c:mainfrom
Conversation
…s Set" to ExtendableEvent The "Update Service Worker Extended Events Set" algorithm stores the input event into the "set of extended events", which is defined as a set of ExtendableEvent objects. To be consistent with this definition and how the algorithm is called (always with ExtendableEvent or its subclasses), this change updates the input type from Event to ExtendableEvent. Bug: w3c#1196
Collaborator
Author
|
@monica-ch Will you take a look? This is a minor argument change to address #1196. |
monica-ch
approved these changes
Jan 23, 2026
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Jan 26, 2026
github-actions bot
added a commit
to yoshisatoyanagisawa/ServiceWorker
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Update Service Worker Extended Events Set" algorithm stores the input event into the "set of extended events", which is defined as a set of ExtendableEvent objects. To be consistent with this definition and how the algorithm is called (always with ExtendableEvent or its subclasses), this change updates the input type from Event to ExtendableEvent.
Bug: #1196
Preview | Diff