In ValidateIncrementalGroupings enforce equivalence not equality.#184
Merged
garretrieger merged 1 commit intow3c:mainfrom Mar 5, 2026
Merged
Conversation
Complex condition finding can produce different but equivalent found conditions for glyphs (where both are valid superset conditions), as a result the incrementally generated groupings can differ from the non-incremental ones via differences in found conditions. In the validation which ensures the incremental and non-incremental groupings are equal don't fail if they differ only by valid found conditions. Found conditions are considered valid if they meet the glyph closure requirement and do not have any additional conditions. This also introduces some tests for GlyphClosureCache which were missing.
garretrieger
force-pushed
the
glyph_group_equivalence
branch
from
2636b62 to
3dba87e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complex condition finding can produce different but equivalent found conditions for glyphs (where both are valid superset conditions), as a result the incrementally generated groupings can differ from the non-incremental ones via differences in found conditions. In the validation which ensures the incremental and non-incremental groupings are equal don't fail if they differ only by valid found conditions. Found conditions are considered valid if they meet the glyph closure requirement and do not have any additional conditions.
This also introduces some tests for GlyphClosureCache which were missing.