Skip to content

Clean up what we've declared "//visibility:public" in the build files.#187

Merged
garretrieger merged 5 commits intow3c:mainfrom
garretrieger:public_api
Mar 10, 2026
Merged

Clean up what we've declared "//visibility:public" in the build files.#187
garretrieger merged 5 commits intow3c:mainfrom
garretrieger:public_api

Conversation

@garretrieger
Copy link
Contributor

@garretrieger garretrieger commented Mar 10, 2026

  • I've reviewed the list of header files that have public visibility and removed it in a few cases that are more implementation details (for example segmentation context and the TRY macros).
  • Added a script which checks that all includes from a public header are themselves public headers and fixed some cases where this wasn't the case.
  • Dropped all of the "IFTB" stuff as it's not used anymore, now that we have a segmenter implemented in this repo.
  • Added name spacing to the various proto messages.

Adds a script to list public api headers and ensure they are in turn only using other public api headers.
This is no longer needed, it existed at the start as a way to get supply font segmentations before we had our own segmenter.
@nyshadhr9
Copy link
Contributor

LGTM

@garretrieger garretrieger merged commit e8b32f0 into w3c:main Mar 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants