Add terms used by the Access Request feature#199
Open
acoburn wants to merge 1 commit into
Open
Conversation
pchampin
approved these changes
Jul 18, 2026
pchampin
left a comment
pchampin
left a comment
Contributor
There was a problem hiding this comment.
The two suggested changes I made in this review are a workaround the punning issue for as:mediaType used as value of leftOperand. It seems to work.
Appart from that, LGTM
Comment on lines
7
to
8
| - id: as | ||
| value: https://www.w3.org/ns/activitystreams# |
Contributor
There was a problem hiding this comment.
Suggested change
| - id: as | |
| value: https://www.w3.org/ns/activitystreams# | |
| - id: as2 | |
| value: https://www.w3.org/ns/activitystreams# |
(the diff above seems buggy -- this proposal is to simply add prefix as2 with the same IRI as as)
| - odrl:purpose | ||
| - odrl:dateTime | ||
| - client | ||
| - dcterms:type |
Contributor
There was a problem hiding this comment.
Suggested change
| - dcterms:type | |
| - dcterms:type | |
| - as2:mediaType |
pchampin
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terms used in the Access Request feature have not been added to the vocabulary and JSON-LD context. This adds almost all of the terms to the
yml2vocabconfiguration file.There are two notable exceptions that need to be handled separately, and may warrant more discussion.
mediaTypefrom Activity Streams 2.0 as a defined property (used in container listings), butyml2vocabdoes not allow terms defined as properties in thevocabulary.ymlfile to be used for@vocabexpansion. In order to usemediaTypeas the value forleftOperand, we would need to consider one of these workarounds:leftOperandvalueyml2vocabto support OWL punning (at present, it only allows terms defined as named individuals if they are included in thevocabulary.ymlfile)lws:StorageResource, which aligns with the term "LWS Resource". It seems like we should align these terms. The simplest approach seems to be to define a term in the vocabulary forlws:Resourceand give it the same definition as LWS Resource, and secondly, change the examples and text that reference lws:StorageResource, changing that to lws:Resource.Please note that all the terms with
external: truewill not appear in the LWS Turtle vocabulary, but they will appear in the JSON-LD context. In most cases those terms will be scoped to thelws:AccessPolicycontext.dcterms:conformsToremains unscoped since it is used in the service definitions of the Storage Description Resource.