Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, a terminology section establishes what things are: their identity, nature and relationships. Behavioral requirements (what they do and how they interact), such as what is added here, belong in normative sections.
I do not believe we should make this change to the definition of
agent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need more clarity for implementation on the flow of interaction e.g. agent -> lws client -> lws-server.
If you agree, where in the spec should we add that detail - it could be covered in the text descriptions that go with the diagrams.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be taken into account in
I recall that it came up while we were discussing that PR and looking at the User entity.
da07c8f seems to address it already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I think the minutes said put this in #159, I was mistaken - I'll close this and bring this text into the description part of the diagram (I've already update the diagrams to use agent instead of user)