Add comprehensive tests for worklist SQL execution algorithm#83
Merged
RobbieMcKinstry merged 1 commit intotrunkfrom Mar 19, 2026
Merged
Add comprehensive tests for worklist SQL execution algorithm#83RobbieMcKinstry merged 1 commit intotrunkfrom
RobbieMcKinstry merged 1 commit intotrunkfrom
Conversation
TEST: Add unit tests for worklist dependency resolution algorithm Introduces a SqlExecutor trait to decouple the worklist algorithm from tokio_postgres::Client, following the sans-I/O pattern used elsewhere (Catalog/FakeCatalog). This enables thorough unit testing with a FakeSqlExecutor test double. New test coverage (16 new tests): - All files succeed on first try / single file / empty input - Dependency error causes retry and eventual success - Linear dependency chain (C->B->A) resolves correctly - Diamond dependency (D->B,C->A) resolves correctly - Circular dependency detection (2 files, 3 files, single file) - Duplicate objects are skipped (counts as progress) - Skip resets the visit counter (prevents false circular detection) - Mixed scenarios (success + dependency + skip) - Partial circular (some succeed, remaining cycle detected) - Max iterations safety limit - Already-correct order requires no retries https://claude.ai/code/session_01BZqd9DHaEauidisXBwyBnf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.