Remove unnecessary collectstatic step from CI test workflow#440
Open
Raghaddahi wants to merge 1 commit into
Open
Remove unnecessary collectstatic step from CI test workflow#440Raghaddahi wants to merge 1 commit into
Raghaddahi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #406
Description
The CI test workflow was running
collectstaticbefore tests, but this is unnecessary because the test settings (apps/guide/settings/test.py) already useCompressedStaticFilesStorage, which serves static files directly from app directories without requiring them to be collected intoSTATIC_ROOT.The
collectstaticcommand was doing nothing useful for the test run. The only static-file-related requirement for tests is thatmanifest.jsonexists (formanifest_loader), which is already handled separately in the workflow.Changes
poetry run python manage.py collectstatic --noinput --clearfrom the CI test jobTesting
make testlocally withDJANGO_SETTINGS_MODULE=apps.guide.settings.testAI usage
AI assisted with the PR description only , all code is reviewed by me.