Skip to content

Remove unnecessary collectstatic step from CI test workflow#440

Open
Raghaddahi wants to merge 1 commit into
mainfrom
remove-collectstatic
Open

Remove unnecessary collectstatic step from CI test workflow#440
Raghaddahi wants to merge 1 commit into
mainfrom
remove-collectstatic

Conversation

@Raghaddahi

@Raghaddahi Raghaddahi commented May 31, 2026

Copy link
Copy Markdown
Member

Relates to #406

Description

The CI test workflow was running collectstatic before tests, but this is unnecessary because the test settings (apps/guide/settings/test.py) already use CompressedStaticFilesStorage, which serves static files directly from app directories without requiring them to be collected into STATIC_ROOT.

The collectstatic command was doing nothing useful for the test run. The only static-file-related requirement for tests is that manifest.json exists (for manifest_loader), which is already handled separately in the workflow.

Changes

  • Removed poetry run python manage.py collectstatic --noinput --clear from the CI test job

Testing

  • Ran make test locally with DJANGO_SETTINGS_MODULE=apps.guide.settings.test
  • All 48 tests pass
  • No lint errors in changed files

AI usage

AI assisted with the PR description only , all code is reviewed by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant