-
Notifications
You must be signed in to change notification settings - Fork 33
RFC 28: Tagging improvements #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kaedroho
wants to merge
1
commit into
main
Choose a base branch
from
tagging-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| # RFC 28: Tagging improvements | ||
|
|
||
| * RFC: 28 | ||
| * Author: Karl Hobley | ||
| * Status: Draft | ||
| * Created: 2018-06-01 | ||
| * Last Modified: 2018-06-01 | ||
|
|
||
| ## Abstract | ||
|
|
||
| At the NHS Wagtail sprint, we looked at the some issues their editors have when creating content for a large site in Wagtail. Some issues were raised around tagging and the search-by-tag UI in the image and document choosers. | ||
|
|
||
| They have thousands of images and they use the “tags” field to taxonomise them in various ways (such as illness, age group and gender). This RFC proposes some changes we can make to Wagtail which should improve the experience for users who tag content in this way. | ||
|
|
||
| ## Tag management | ||
|
|
||
| Currently, it’s really easy for users to add new tags, they just type the name in the “tags" field and hit enter. Suggestions for names are given but it’s easy to ignore this. | ||
|
|
||
| This means that you can easily end up with duplicate tags which fragments the content making it harder to search using that tag. The only way to resolve this is to find all the incorrectly tagged items and manually assign the correct tag, but this does not remove the incorrect tag from suggestions which could cause it to be assigned to something else by mistake. | ||
|
|
||
| Also, it’s possible that a site would want to predefine tags to prevent inconsistency. Using age brackets as an example, one editor might tag an image “Ages 18-25” while another editor might tag an image with with “Ages 20-25” and yet another might use “Young adult”. | ||
|
|
||
| Here’s some ideas of how this can be improved: | ||
|
|
||
| **Make it (slightly) harder to add new tags** | ||
|
|
||
| Instead of allowing the user to just hit enter to add a new tag, add an “Add tag” button within the suggestions. This should trigger the user to consider using an existing tag rather than create a new one. | ||
|
|
||
| This is how Github allows adding “Labels” to an issue: | ||
|
|
||
|  | ||
|
|
||
| **Add a “Tag management” interface** | ||
|
|
||
| Add a separate interface in Wagtail to allow admins/moderators to manage the available tags. This would allow defining tags before inserting content and renaming tags for consistency. This could also include merging duplicate tags as well. | ||
|
|
||
| This could be used in conjunction with free tagging or free tagging could be disabled entirely. | ||
|
|
||
| ## Image/Document choosers | ||
|
|
||
| There’s some shortcomings in the image/document choosers which could be improved to make finding images with tags more efficient for the user. | ||
|
|
||
| Here’s a screenshot of the image chooser from the bakery demo (I had to make up some tags). Currently, the “Bread” tag is selected. | ||
|
|
||
|  | ||
|
|
||
| There are some problems here: | ||
|
|
||
| 1. It’s not possible to filter by a tag that isn’t in the top ten “Popular tags” | ||
| 2. It’s not possible to filter by more than one tag at a time | ||
| 3. The only way to deselect the tag is to close and reopen the chooser | ||
| 4. There is no indication to the user that the “Bread” tag is actually selected | ||
|
|
||
| **Add “Tags” field to the chooser** | ||
|
|
||
| The obvious solution to this is to add a “Tags” field, like what we have on the model, underneath the “Collections” field. This provides a solution to all of the points above: | ||
|
|
||
|  | ||
|
|
||
| **Change the layout of the chooser form** | ||
|
|
||
| Adding a new tags field to the chooser increases the amount of vertical space used by the form so we should tweak the layout to reduce the amount of vertical space that’s used. | ||
|
|
||
| Since the labels are redundent, we can remove them which allows us to put two fields on the same row: | ||
|
|
||
|  | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making use of the permission system would probably work well here: users get free tagging if they have 'add' permission over the tag model, and access to the tag management interface if they have edit/delete permission.