Added partial support for retina images#30
Open
DannyvanHolten wants to merge 3 commits into
Open
Conversation
Contributor
|
Instead of changing our main functions to give support to other plugins we should consider adding new functions to extend our main functions. We could also have a look at filters to add this support. |
Member
Author
|
I think this functionality should be core for our plug-in. Cropping images is our core business, so cropping retina images as well. |
| $imageFilePath | ||
| ); | ||
| // Loop trough all the image qualities (normal & retina) | ||
| foreach ($imageFilePaths as $retina => $imageFilePath) { |
Contributor
There was a problem hiding this comment.
as $imageSize => $imageFilePath
|
|
||
| // Add the retina image if it exists (We're using 2 instead of @2x for multiplications) | ||
| if (file_exists($uploadDir . $retinaFileName)) { | ||
| $imageFilePaths['2'] = $uploadDir . $retinaFileName; |
Contributor
There was a problem hiding this comment.
$images[] = [
'src'=> 'path....',
'multiply'=> '1' // or 2
]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.