PHP 8.4 compatibility#18
Open
andreasvonburg wants to merge 3 commits intowallee-payment:masterfrom
Open
Conversation
added 2 commits
July 14, 2025 22:04
nikolai-schmid
approved these changes
Jul 31, 2025
nikolai-schmid
left a comment
nikolai-schmid
left a comment
There was a problem hiding this comment.
Glad to see this moving forward! thank you for taking a look.
|
I do support this request |
|
these changes look good to me; it would be nice to have them integrated. |
|
Hi, thank you for the pull request; although it looks good from high level, we will run some additional check internally and it should be approved in the following couple of weeks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered numerous deprecation warnings when using your library with PHP 8.4. To address them, I needed to make certain array types nullable. Nullable types exist since PHP 7.1. Your documentation states compatibility from PHP 5.6.0 onward, but I don't think this is necessary. As of now, PHP 8.1 is the oldest version still actively supported and I don't think the Wallee SDK would be used in an environment below PHP 7.1.