fix: use literal envPrefix queries for Vite Task#1
Closed
wan9chi wants to merge 61 commits into
Closed
Conversation
Co-authored-by: Vladimir Sheremet <sleuths.slews0s@icloud.com> Co-authored-by: Hiroshi Ogawa <hi.ogawa.zz@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: cwkang <cwkang@dozn.co.kr>
…WED_HOSTS (vitejs#21501) Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
…22453) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…th follow-up transforms (vitejs#22428)
… known `as` types (vitejs#21863) Co-authored-by: nathanhleung <nathanhleung@users.noreply.github.com> Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Signed-off-by: Kushagra963-lab <147275307+Kushagra963-lab@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…f having a separate FBM `DevEnvironment` (vitejs#22587) Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
…22678) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Taisei Mima <bhbstar.me@gmail.com>
…on (vitejs#22638) Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…tejs#22702) Co-authored-by: sanjibani <18418553+sanjibani@users.noreply.github.com>
wan9chi
force-pushed
the
codex/vite-envprefix-getenvs-prefix
branch
from
b91a134 to
e47428a
Compare
Co-authored-by: GPT-5 Codex <codex@openai.com>
wan9chi
force-pushed
the
codex/vite-envprefix-getenvs-prefix
branch
from
e47428a to
a99d301
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Vite Task integration reports
envPrefixvalues togetEnvsas glob patterns like${prefix}*. That creates a corner case where anenvPrefixcontaining*is treated as a wildcard by the task client, while Vite itself treatsenvPrefixas a literal string prefix.Solution
Use the literal prefix query form from
@voidzero-dev/vite-task-client@0.2.0, added in voidzero-dev/vite-task#472, and callgetEnvs({ prefix })for each configuredenvPrefix.Compatibility
This does not create a compatibility problem because no Vite release containing the
vite-task-clientintegration has shipped yet. The integration can move to the new query form before it becomes public.