Skip to content

fix: Openshift issues#167

Merged
wnevis-cmyk merged 7 commits intov2from
fix/openShiftIssues
Apr 30, 2026
Merged

fix: Openshift issues#167
wnevis-cmyk merged 7 commits intov2from
fix/openShiftIssues

Conversation

@wnevis-cmyk
Copy link
Copy Markdown

  • Fixes security context issues with minio-operator
  • Adds flag for openshift for grafana-operator
  • Adds support for fsGroup for strimzi-operator (and underlying kafka)
    • Forces fsGroup 0 (root) for local crc deployments. Openshift should (?) automatically assign this in a regular openshift cluster
  • Abstracts openshift-specific settings into a separate overlay

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f68645a-d39a-4285-a218-65a6c71d0dbf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/openShiftIssues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wnevis-cmyk wnevis-cmyk changed the title Fix: openshift issues fix: openshift issues Apr 28, 2026
@wnevis-cmyk wnevis-cmyk changed the title fix: openshift issues fix: Openshift issues Apr 28, 2026
Comment thread api/v2/weightsandbiases_types.go Outdated
Name string `json:"name,omitempty"`
Telemetry Telemetry `json:"telemetry,omitempty"`
SkipDataRecovery bool `json:"skipDataRecovery,omitempty"`
FsGroup *int64 `json:"fsGroup,omitempty"`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something the user should be setting directly? it feels like a value we should be choosing.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you're right, it shouldn't be. It should be set to 0 if it's an openshift deployment, and nil if not (at least, that's what worked in my dev environment).

Copy link
Copy Markdown
Author

@wnevis-cmyk wnevis-cmyk Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and removed that from the API. Instead, I'm setting it via an environment variable which is configured via the overlay I'm using to push the podSecurityContext info for the controller-manager. Is that a better approach?

@wnevis-cmyk wnevis-cmyk merged commit 1d0a0ef into v2 Apr 30, 2026
5 checks passed
@wnevis-cmyk wnevis-cmyk deleted the fix/openShiftIssues branch April 30, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants