Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/utils/gvk.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ func IsRegistered(scheme *runtime.Scheme, obj runtime.Object) bool {
if err != nil || len(gvks) == 0 {
return false
}
return IsServerResource(fmt.Sprintf("%s.%s/%s", gvks[0].Kind, gvks[0].Group, gvks[0].Kind))
return IsServerResource(fmt.Sprintf("%s.%s/%s", gvks[0].Kind, gvks[0].Group, gvks[0].Version))
}

func AddServerResource(resource string) {
Expand Down
32 changes: 32 additions & 0 deletions pkg/utils/gvk_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
package utils

import (
"testing"

"k8s.io/apimachinery/pkg/runtime"
gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
)

func TestIsRegisteredUsesKindGroupVersion(t *testing.T) {
scheme := runtime.NewScheme()
if err := gatewayv1.Install(scheme); err != nil {
t.Fatalf("install gateway api scheme: %v", err)
}

t.Run("returns true when server resource key uses version", func(t *testing.T) {
serverResources = map[string]bool{}
AddServerResource("HTTPRoute.gateway.networking.k8s.io/v1")

if !IsRegistered(scheme, &gatewayv1.HTTPRoute{}) {
t.Fatalf("expected HTTPRoute to be registered")
}
})

t.Run("returns false when server resource key is missing", func(t *testing.T) {
serverResources = map[string]bool{}

if IsRegistered(scheme, &gatewayv1.HTTPRoute{}) {
t.Fatalf("expected HTTPRoute to be unregistered")
}
})
}
Loading