fix: Improve MUI theme integration …#620
Merged
Merged
Conversation
- Automatically set dark mode so it doesnt break existing apps - Type-only import: pulls in Nova's `declare module "@mui/material/styles
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the library’s Material UI theme integration to be dark-mode-only compatible, clarifies/introduces migration guidance around createNovaTheme vs createNovaMuiTheme, and bumps core dependencies (@wandelbots/design-tokens, @wandelbots/nova-js) to newer versions.
Changes:
- Added sanitization in
createNovaThemeto preventpalette.mode: "light"from crashing upstream, and documented dark-only support. - Updated theme type augmentation import strategy to be type-only (module augmentation without runtime side effects).
- Upgraded
@wandelbots/design-tokensand@wandelbots/nova-js(with corresponding lockfile updates).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| stories/WandelbotsTheme.mdx | Documents dark-only theme support and migration notes for theme creation API. |
| stories/ThemingComponents.mdx | Adds migration guidance for renamed/deprecated theme factory export. |
| src/themes/theming.ts | Implements palette.mode sanitization and keeps deprecated alias export. |
| src/themes/themeTypes.ts | Switches to type-only import for MUI theme augmentation from design-tokens. |
| package.json | Bumps @wandelbots/design-tokens and @wandelbots/nova-js versions. |
| pnpm-lock.yaml | Locks updated dependency graph for the upgraded packages. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
wandeljan
force-pushed
the
feat/mui-theme-fixes
branch
from
July 13, 2026 11:02
0ef4902 to
3b56773
Compare
Strieglitz
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.