chore: 릴리즈 시 docs-sync workflow 직접 호출하도록 단순화#496
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
Walkthrough릴리스 게시 트리거 워크플로우에 변경사항문서 배포 워크플로우 통합
예상 코드 리뷰 노력🎯 3 (Moderate) | ⏱️ ~20 minutes 관련 PR
제안 라벨
제안 리뷰어
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/auto-deploy-docs.yml:
- Around line 7-9: The workflow currently lacks an explicit permissions block so
the job sync-and-deploy (jobs.sync-and-deploy) runs with default GITHUB_TOKEN
privileges; add an explicit permissions stanza for the workflow or for that job
to minimize scope (e.g., set permissions: none if you exclusively use a separate
GitHub App token, or declare only required scopes such as contents: read and
pages: write) to ensure the job.run-on remains limited to the minimum privileges
needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 37682c78-f99c-46e3-9969-a83176ea045a
📒 Files selected for processing (1)
.github/workflows/auto-deploy-docs.yml
| sync: | ||
| uses: wanteddev/montage-web/.github/workflows/docs-sync.yml@main | ||
| secrets: inherit |
There was a problem hiding this comment.
uses: wanteddev/montage-web/.github/workflows/docs-sync.yml@main
-> montage-ios 코드 상태에서 docs-sync 실행합니다.
그러나 docs-sync 내부 코드에서 ./.github/actions/pnpm-install/action.yml을 참조하고 있었는데,
현재 코드 베이스는 montage-ios이기 때문에 pnpm-install/action.yml를 찾지 못하여 오류가 발생했습니다.
기존에는 sync -> 변경사항이 있다면 문서 배포 까지 이 workflow(auto-deploy-docs) 에서 진행했는데,
montage-web의 docs-sync.yml 에서 진행하도록 위임하고, 여기 저장소에서는 단순 github cli를 통해 dispatch만 하도록 변경했습니다
개요
수정사항
docs-deploy.yml을 직접 호출하던 구조를docs-sync.yml호출로 변경sync-and-deploy잡으로 통합docs-sync.yml의platform=mobile,deploy=true입력을 전달하여 sync 이후 배포까지 한 번에 트리거미리보기
워크플로 변경 — 미리보기 해당 없음