Skip to content

feat: TextButton 타이포·아이콘·모서리·Interaction 토큰 갱신#498

Merged
knine79 merged 1 commit into
release/4.0.0from
feat/WRP-941
Jun 2, 2026
Merged

feat: TextButton 타이포·아이콘·모서리·Interaction 토큰 갱신#498
knine79 merged 1 commit into
release/4.0.0from
feat/WRP-941

Conversation

@knine79
Copy link
Copy Markdown
Contributor

@knine79 knine79 commented Jun 1, 2026

개요

TextButton(Button의 .text variant) 사이즈 토큰을 디자인 시안에 맞춰 갱신합니다. 변경은 .text 분기에 한정되어 solid/outlined 버튼에는 영향이 없습니다.

수정사항

속성 Small Medium
타이포 Label1 (변경 없음) Body1 → Body2
아이콘 16 (변경 없음) 20 → 18
모서리(Interaction) 6 → 8 6 → 10
Interaction 가로 오프셋 7 → 6 7 → 8
Interaction 세로 오프셋 4 (변경 없음) 4 (변경 없음)
  • Loading 크기·min-height는 4.0 사이즈 토큰 갱신(c40638cb5)·기존 minHeight: contentHeight에 이미 반영되어 변경하지 않았습니다.
  • Figma dev 스펙 재확인 결과 Small 가로 오프셋도 7→6으로 함께 정정했습니다(티켓엔 Medium만 명시).

미리보기

작업 전 작업 후
스크린샷 스크린샷

Figma 시안(node 26933-125045) 기준 구현. Ready 전환 전 Blueprint 스크린샷 첨부 예정.

@knine79 knine79 self-assigned this Jun 1, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 16c58590-d5ad-4476-8987-b6fc920ddf6d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/WRP-941

Comment @coderabbitai help to get the list of available commands and usage tips.

@knine79 knine79 added this to the 4.0.0 milestone Jun 1, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Sources/Montage/1 Components/2 Actions/Button.swift (1)

1-625: 변경 후 make 명령을 실행하여 문서를 업데이트하세요.

Sources/Montage/ 디렉토리의 Swift 소스 파일을 수정한 후에는 make 명령을 실행하여 documentation/ 폴더와 THIRD_PARTY_LICENSES.md 파일을 업데이트해야 합니다.

As per coding guidelines: "Execute make command after modifying Swift source files in Sources/Montage/ to update documentation/ folder and THIRD_PARTY_LICENSES.md"

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Sources/Montage/1` Components/2 Actions/Button.swift around lines 1 - 625,
You modified Sources/Montage Button.swift; after changing Swift sources under
Sources/Montage (e.g., Button type and its methods: init, resolveColor, body,
modifiers like loading/disable), run the project's make command to regenerate
the documentation/ folder and THIRD_PARTY_LICENSES.md, then add and commit those
generated artifacts alongside your code changes so the docs and license file
stay in sync with the updated Button implementation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@Sources/Montage/1` Components/2 Actions/Button.swift:
- Around line 1-625: You modified Sources/Montage Button.swift; after changing
Swift sources under Sources/Montage (e.g., Button type and its methods: init,
resolveColor, body, modifiers like loading/disable), run the project's make
command to regenerate the documentation/ folder and THIRD_PARTY_LICENSES.md,
then add and commit those generated artifacts alongside your code changes so the
docs and license file stay in sync with the updated Button implementation.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f0bef720-8030-4c6d-a9d9-380d39ea7376

📥 Commits

Reviewing files that changed from the base of the PR and between f4d5151 and 3fd9573.

📒 Files selected for processing (1)
  • Sources/Montage/1 Components/2 Actions/Button.swift

@github-actions github-actions Bot added the accepted This issue has been reviewed. label Jun 1, 2026
@knine79 knine79 marked this pull request as ready for review June 2, 2026 02:16
@knine79 knine79 requested a review from a team as a code owner June 2, 2026 02:16
@knine79 knine79 requested review from deholic and removed request for a team June 2, 2026 02:16
@knine79 knine79 merged commit aac56a1 into release/4.0.0 Jun 2, 2026
3 of 4 checks passed
@knine79 knine79 deleted the feat/WRP-941 branch June 2, 2026 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted This issue has been reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant