feat: TextButton 타이포·아이콘·모서리·Interaction 토큰 갱신#498
Conversation
Refs: WRP-941
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Sources/Montage/1 Components/2 Actions/Button.swift (1)
1-625: 변경 후make명령을 실행하여 문서를 업데이트하세요.Sources/Montage/ 디렉토리의 Swift 소스 파일을 수정한 후에는
make명령을 실행하여 documentation/ 폴더와 THIRD_PARTY_LICENSES.md 파일을 업데이트해야 합니다.As per coding guidelines: "Execute
makecommand after modifying Swift source files in Sources/Montage/ to update documentation/ folder and THIRD_PARTY_LICENSES.md"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Sources/Montage/1` Components/2 Actions/Button.swift around lines 1 - 625, You modified Sources/Montage Button.swift; after changing Swift sources under Sources/Montage (e.g., Button type and its methods: init, resolveColor, body, modifiers like loading/disable), run the project's make command to regenerate the documentation/ folder and THIRD_PARTY_LICENSES.md, then add and commit those generated artifacts alongside your code changes so the docs and license file stay in sync with the updated Button implementation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@Sources/Montage/1` Components/2 Actions/Button.swift:
- Around line 1-625: You modified Sources/Montage Button.swift; after changing
Swift sources under Sources/Montage (e.g., Button type and its methods: init,
resolveColor, body, modifiers like loading/disable), run the project's make
command to regenerate the documentation/ folder and THIRD_PARTY_LICENSES.md,
then add and commit those generated artifacts alongside your code changes so the
docs and license file stay in sync with the updated Button implementation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f0bef720-8030-4c6d-a9d9-380d39ea7376
📒 Files selected for processing (1)
Sources/Montage/1 Components/2 Actions/Button.swift
개요
TextButton(Button의
.textvariant) 사이즈 토큰을 디자인 시안에 맞춰 갱신합니다. 변경은.text분기에 한정되어solid/outlined버튼에는 영향이 없습니다.수정사항
c40638cb5)·기존minHeight: contentHeight에 이미 반영되어 변경하지 않았습니다.7→6으로 함께 정정했습니다(티켓엔 Medium만 명시).미리보기