Skip to content

Update spec for describing complex dependencies #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
izumin5210 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update spec for describing complex dependencies #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions spec/computed_model_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
let(:raw_user_ids) { [raw_user1, raw_user2, raw_user3, raw_user4].map(&:id) }
before { raw_user3.destroy! }

let!(:raw_book1) { create(:raw_book, author_id: raw_user2.id, title: "Book One") }
let!(:raw_book2) { create(:raw_book, author_id: raw_user4.id, title: "Book Two") }
let!(:raw_book3) { create(:raw_book, author_id: raw_user2.id, title: "Book Three") }
let!(:raw_book4) { create(:raw_book, author_id: raw_user2.id, title: "Book Four") }
let!(:raw_book1) { create(:raw_book, author_id: raw_user2.id, title: "Book One", published_at: Date.new(2020, 4, 20)) }
let!(:raw_book2) { create(:raw_book, author_id: raw_user4.id, title: "Book Two", published_at: Date.new(2020, 7, 9)) }
let!(:raw_book3) { create(:raw_book, author_id: raw_user2.id, title: "Book Three", published_at: Date.new(2020, 10, 1)) }
let!(:raw_book4) { create(:raw_book, author_id: raw_user2.id, title: "Book Four", published_at: Date.new(2021, 2, 13)) }
let!(:raw_book5) { create(:raw_book, author_id: raw_user2.id, title: "Book Five", published_at: nil) }

class self::Sandbox
class User
Expand All @@ -36,12 +37,17 @@ def self.list(ids, with:)
RawUser.where(id: ids).map { |raw_user| User.new(raw_user) }
end

define_loader :books, key: -> { id } do |keys, subdeps|
define_loader :books_with_unpublished, key: -> { id } do |keys, subdeps|
Book.list(user_ids: keys, with: subdeps).group_by(&:author_id)
end

delegate_dependency :name, to: :raw_user

dependency books_with_unpublished: [:published]
computed def books
books_with_unpublished.select(&:published)
end

dependency :name
computed def fancy_name
"#{name}-san"
Expand All @@ -68,11 +74,16 @@ def self.list(user_ids:, with:)
bulk_load_and_compute(with, user_ids: user_ids)
end

define_primary_loader :raw_book do |_subdeps, user_ids:, **_options|
RawBook.where(author_id: user_ids).map { |raw_book| Book.new(raw_book) }
define_primary_loader :raw_book do |subdeps, user_ids:, **_options|
RawBook.where(author_id: user_ids).select(:id, *subdeps).map { |raw_book| Book.new(raw_book) }
end

delegate_dependency :title, to: :raw_book
delegate_dependency :title, to: :raw_book, include_subdeps: true

dependency raw_book: [:published_at]
computed def published
!!raw_book.published_at
end
end
end

Expand Down
1 change: 1 addition & 0 deletions spec/support/db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
create_table "books", force: :cascade do |t|
t.string "title", null: false
t.bigint "author_id", null: false
t.datetime "published_at", precision: 6, null: false
t.datetime "created_at", precision: 6, null: false
t.datetime "updated_at", precision: 6, null: false
t.index ["author_id"], name: "index_books_on_author_id"
Expand Down