Skip to content

Comments

🔧 update (web): correct path references in dev notice fallback page#9

Merged
warengonzaga merged 6 commits intowarengonzaga:devfrom
youhanasheriff:fix/dev-notice-paths
Feb 21, 2026
Merged

🔧 update (web): correct path references in dev notice fallback page#9
warengonzaga merged 6 commits intowarengonzaga:devfrom
youhanasheriff:fix/dev-notice-paths

Conversation

@youhanasheriff
Copy link
Contributor

Summary

Fixes incorrect path references in the dev notice fallback page served when the Svelte frontend isn't running.

Closes #8

Problem

The buildDevNotice() function in src/web/src/server.ts displays apps/web as the command path, but the actual project structure uses src/web. This causes confusion and errors when users follow the displayed instructions.

Changes

Updated two path references in the buildDevNotice() HTML template:

Before (Incorrect) After (Correct)
bun run --cwd apps/web dev bun run --cwd src/web dev
bun run --cwd apps/web build bun run --cwd src/web build

Files Changed

  • src/web/src/server.ts — 2 lines changed (lines 421, 425)

Checklist

  • PR targets the dev branch
  • Commits follow the Clean Commit convention
  • Issue exists and is referenced (Closes #8)
  • Code builds successfully
  • No tests required (static HTML content fix)

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2026

CLA assistant check
All committers have signed the CLA.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix incorrect path references in the development notice fallback page that displays when the Svelte frontend isn't running. The page was incorrectly showing apps/web instead of the actual project path src/web.

Changes:

  • Corrected two path references in the dev notice HTML from apps/web to src/web
  • Changed all CLI dependencies to devDependencies (appears to be an error)
  • Updated release workflow action version from v1.3.0 to v1.4.2

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/web/src/server.ts Corrected path references in buildDevNotice() HTML template from apps/web to src/web
src/cli/package.json All dependencies moved to devDependencies (problematic change unrelated to PR purpose)
bun.lock Lock file updates reflecting package.json changes and version bumps to 1.1.0
.github/workflows/release.yml GitHub Action version updated from v1.3.0 to v1.4.2 (unrelated to PR purpose)

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

@warengonzaga
Copy link
Owner

Hey @youhanasheriff 👋 Thanks for the fix!

I've just merged main into dev so the base branch is now up to date. The unrelated changes (CI workflow updates, CLI deps restructuring) that were showing up in your PR diff are actually from main commits — not from your changes.

Could you please rebase your branch on the updated dev branch? This will clean up the PR diff to only show your path fix commit:

git fetch upstream
git rebase upstream/dev
git push --force-with-lease

After the rebase, the review comments about src/cli/package.json and .github/workflows/release.yml should no longer apply since those files won't be part of your diff anymore. Your actual fix (apps/websrc/web) looks good! 🐾

Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly rebase your code from the dev branch. Sorry for the trouble!

@warengonzaga
Copy link
Owner

Use the latest code from the dev branch thanks!

@warengonzaga
Copy link
Owner

I'll merge this and correct the base code @youhanasheriff thanks for your contribution.

@warengonzaga warengonzaga merged commit 96838af into warengonzaga:dev Feb 21, 2026
1 check passed
@youhanasheriff
Copy link
Contributor Author

@warengonzaga ,
You did it yourself. Thanks!

@warengonzaga
Copy link
Owner

@warengonzaga , You did it yourself. Thanks!

Yeah, needed the fix badly to make the CLI work on dev version for local testing.
Try it yourself bun install -g tinyclaw@dev

@youhanasheriff
Copy link
Contributor Author

youhanasheriff commented Feb 21, 2026 via email

warengonzaga added a commit that referenced this pull request Feb 21, 2026
…haul (#10)

* 📦 new: add update checker functionality and context injection

* 📦 new: implement update checker with caching and runtime detection

* 🧪 test: add comprehensive tests for update checker module

* 📦 new: add updateContext to AgentContext for software updates

* 📦 new: add software update check and context to start command

* 📦 new: update package versions to 1.0.1 across all packages

* ⚙️ setup: update CI workflows for release process and permissions

* 🔧 update: enhance version parsing in isNewerVersion function

* 📦 new: add build step for all packages in CI workflow

* ⚙️ setup (ci): update package-build-flow-action to v2.0.1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup: enforce clean commit convention with husky and ci

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (husky): add clean commit validation hook

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): fix security, guards, and validation issues

- add if-guard to package/container jobs (main push only)
- narrow ci.yml top-level permissions to contents: read
- add per-job permissions for package and container jobs
- remove unused packages/security-events write from release.yml
- fix commit-lint push range to validate all commits (before..after)
- quote SHA interpolations in commit-lint PR log command
- remove duplicate bun run build step from package.yml
- add --bail flag to pre-commit bun test hook
- add msgFile undefined guard in validate-commit-msg.mjs
- make variation selector optional for trash and gear emojis
- strengthen readCache to validate latest and runtime field types

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): remove redundant permissions from reusable workflow calls

permissions are already defined in the called workflows (package.yml,
container.yml) - specifying them in the caller causes startup_failure
on duplicate runs triggered by open PRs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔧 update (ci): handle initial push and improve update-checker test

- update commit-lint workflow to capture all reachable commits on initial push
- improve update-checker test to assert cache file absence when fetch fails

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 📦 new (landing): add landing page with svelte and tailwindcss

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): add deploy workflow for landing page

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (landing): add build:landing script and update lockfile

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (husky): add error handling and allow revert commits

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔒 security (update-checker): sanitize version and url for prompt injection

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🧪 test (update-checker): add sanitizeForPrompt tests and improve mocking

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): pin action shas and scope deploy permissions

- pin all GitHub Actions to full commit SHAs for supply chain security
- move pages/id-token permissions to deploy job only
- pin bun version to 1.2.x and use --frozen-lockfile
- use dynamic concurrency group name with workflow prefix

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔒 security (core): harden update checker cache and fetch logic

- validate runtime value against allowed list when reading cache
- sanitize current version before embedding in prompt context
- move AbortController setup outside try block and use finally to clear timeout

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 📦 new (landing): extract GitHubIcon component and improve accessibility

- add reusable GitHubIcon Svelte component to replace inline SVG duplication
- add skip-to-main-content link for keyboard navigation
- add aria-label to primary nav element
- add aria-hidden to decorative SVG icons

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔧 update (landing): improve scrollbar styling and Firefox support

- add scrollbar-width and scrollbar-color for Firefox compatibility
- use CSS variable for scrollbar thumb hover color
- remove quoted font family name for Inter

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔧 update (landing): clarify QuickStart step 3 description

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): streamline CI workflows by removing unused jobs

* 🗑️ remove: delete pre-commit script for bun test

* 🔧 update (ci): add build step for workspace packages

* 🔧 update (dockerfile): upgrade bun version for builder and production stages

* 🚀 release: bump version to 1.1.0 for all packages

* 🔧 update (dockerfile): remove frozen-lockfile option from bun install

* 📦 new: add dev:landing script for development of landing page

* 📖 docs: update README with model names and licensing information

* ⚙️ setup: update release action to v1.2.1 and change token secret

* 📖 docs: update commit message guidelines for breaking changes

* 🔧 update: enhance commit message validation for breaking changes

* ⚙️ setup: update release action to v1.2.2

* ⚙️ setup: update actions/checkout version in CI workflow

* ⚙️ setup: update actions/checkout version in CI workflow

* ⚙️ setup: update actions/checkout version in CI workflow

* ⚙️ setup: update actions/checkout version in CI workflow

* ⚙️ setup: remove version check job and update release action to v1.3.0

* 🔧 update (ci): upgrade release-build-flow-action to v1.4.3

* 🔧 update: change shebang from node to bun

* 🔧 update (web): correct path references in dev notice fallback page (#9)

* 🔧 update (cli): move bundled deps to devDependencies for global install

* 🔧 update (ci): upgrade release-build-flow-action to v1.4.0

* 🔧 update (ci): upgrade release-build-flow-action to v1.4.1

* 🔧 update (ci): upgrade release-build-flow-action to v1.4.2

* 🔧 update (web): correct path references in dev notice fallback page

---------

Co-authored-by: Waren Gonzaga <opensource@warengonzaga.com>

* 🔧 update (cli): add auto-build for web ui in setup --web

* 🔧 update (cli): change build command to use process.execPath

* 🔧 update (cli): add webRoot to setupWebUI configuration

* 🔧 update (cli): add webRoot to createWebUI configuration

* 🔧 update (web): allow override of webRoot in resolveUiPaths and findStaticFile

* 📦 new: outbound gateway with SSE push and channel routing

* 📦 new: wire nudge engine, agent tools, and update check into start

* 📦 new: nudge engine with intercom wiring and delivery queue

* 📦 new: nudge user preferences with config and API endpoints

* 📦 new: outbound messaging for Discord and Friends channels

* 📦 new: add gateway and nudge package.json to Dockerfile

* 📦 new: companion nudge system with mood roulette

* 📦 new: add companion jobs and touch activity mocks

* 🔧 update (agentloop): prevent feedback loop by refining tool call handling

* 🔧 update: fix regex for commit message scope to allow uppercase letters

* 📦 new: add SSE push channel for receiving nudges and proactive messages

* 🔧 update: enhance prompt injection defense for internal system users

* 🔧 update: re-check auth status periodically to handle session expiry

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Youhana Sheriff <youhanasheriff@gmail.com>
@youhanasheriff youhanasheriff deleted the fix/dev-notice-paths branch February 21, 2026 20:35
warengonzaga added a commit that referenced this pull request Feb 22, 2026
* 📦 new: add update checker functionality and context injection

* 📦 new: implement update checker with caching and runtime detection

* 🧪 test: add comprehensive tests for update checker module

* 📦 new: add updateContext to AgentContext for software updates

* 📦 new: add software update check and context to start command

* 📦 new: update package versions to 1.0.1 across all packages

* ⚙️ setup: update CI workflows for release process and permissions

* 🔧 update: enhance version parsing in isNewerVersion function

* 📦 new: add build step for all packages in CI workflow

* ⚙️ setup (ci): update package-build-flow-action to v2.0.1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup: enforce clean commit convention with husky and ci

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (husky): add clean commit validation hook

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): fix security, guards, and validation issues

- add if-guard to package/container jobs (main push only)
- narrow ci.yml top-level permissions to contents: read
- add per-job permissions for package and container jobs
- remove unused packages/security-events write from release.yml
- fix commit-lint push range to validate all commits (before..after)
- quote SHA interpolations in commit-lint PR log command
- remove duplicate bun run build step from package.yml
- add --bail flag to pre-commit bun test hook
- add msgFile undefined guard in validate-commit-msg.mjs
- make variation selector optional for trash and gear emojis
- strengthen readCache to validate latest and runtime field types

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): remove redundant permissions from reusable workflow calls

permissions are already defined in the called workflows (package.yml,
container.yml) - specifying them in the caller causes startup_failure
on duplicate runs triggered by open PRs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔧 update (ci): handle initial push and improve update-checker test

- update commit-lint workflow to capture all reachable commits on initial push
- improve update-checker test to assert cache file absence when fetch fails

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 📦 new (landing): add landing page with svelte and tailwindcss

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): add deploy workflow for landing page

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (landing): add build:landing script and update lockfile

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (husky): add error handling and allow revert commits

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔒 security (update-checker): sanitize version and url for prompt injection

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🧪 test (update-checker): add sanitizeForPrompt tests and improve mocking

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): pin action shas and scope deploy permissions

- pin all GitHub Actions to full commit SHAs for supply chain security
- move pages/id-token permissions to deploy job only
- pin bun version to 1.2.x and use --frozen-lockfile
- use dynamic concurrency group name with workflow prefix

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔒 security (core): harden update checker cache and fetch logic

- validate runtime value against allowed list when reading cache
- sanitize current version before embedding in prompt context
- move AbortController setup outside try block and use finally to clear timeout

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 📦 new (landing): extract GitHubIcon component and improve accessibility

- add reusable GitHubIcon Svelte component to replace inline SVG duplication
- add skip-to-main-content link for keyboard navigation
- add aria-label to primary nav element
- add aria-hidden to decorative SVG icons

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔧 update (landing): improve scrollbar styling and Firefox support

- add scrollbar-width and scrollbar-color for Firefox compatibility
- use CSS variable for scrollbar thumb hover color
- remove quoted font family name for Inter

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* 🔧 update (landing): clarify QuickStart step 3 description

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* ⚙️ setup (ci): streamline CI workflows by removing unused jobs

* 🗑️ remove: delete pre-commit script for bun test

* 🔧 update (ci): add build step for workspace packages

* 🔧 update (dockerfile): upgrade bun version for builder and production stages

* 🚀 release: bump version to 1.1.0 for all packages

* 🔧 update (dockerfile): remove frozen-lockfile option from bun install

* 📦 new: add dev:landing script for development of landing page

* 📖 docs: update README with model names and licensing information

* ⚙️ setup: update release action to v1.2.1 and change token secret

* 📖 docs: update commit message guidelines for breaking changes

* 🔧 update: enhance commit message validation for breaking changes

* ⚙️ setup: update release action to v1.2.2

* ⚙️ setup: update actions/checkout version in CI workflow

* ⚙️ setup: update actions/checkout version in CI workflow

* ⚙️ setup: update actions/checkout version in CI workflow

* ⚙️ setup: update actions/checkout version in CI workflow

* ⚙️ setup: remove version check job and update release action to v1.3.0

* 🔧 update (ci): upgrade release-build-flow-action to v1.4.3

* 🔧 update: change shebang from node to bun

* 🔧 update (web): correct path references in dev notice fallback page (#9)

* 🔧 update (cli): move bundled deps to devDependencies for global install

* 🔧 update (ci): upgrade release-build-flow-action to v1.4.0

* 🔧 update (ci): upgrade release-build-flow-action to v1.4.1

* 🔧 update (ci): upgrade release-build-flow-action to v1.4.2

* 🔧 update (web): correct path references in dev notice fallback page

---------

Co-authored-by: Waren Gonzaga <opensource@warengonzaga.com>

* 🔧 update (cli): add auto-build for web ui in setup --web

* 🔧 update (cli): change build command to use process.execPath

* 🔧 update (cli): add webRoot to setupWebUI configuration

* 🔧 update (cli): add webRoot to createWebUI configuration

* 🔧 update (web): allow override of webRoot in resolveUiPaths and findStaticFile

* 📦 new: outbound gateway with SSE push and channel routing

* 📦 new: wire nudge engine, agent tools, and update check into start

* 📦 new: nudge engine with intercom wiring and delivery queue

* 📦 new: nudge user preferences with config and API endpoints

* 📦 new: outbound messaging for Discord and Friends channels

* 📦 new: add gateway and nudge package.json to Dockerfile

* 📦 new: companion nudge system with mood roulette

* 📦 new: add companion jobs and touch activity mocks

* 🔧 update (agentloop): prevent feedback loop by refining tool call handling

* 🔧 update: fix regex for commit message scope to allow uppercase letters

* 📦 new: add SSE push channel for receiving nudges and proactive messages

* 🔧 update: enhance prompt injection defense for internal system users

* 🔧 update: re-check auth status periodically to handle session expiry

* ⚙️ setup: update release-build-flow-action to v1.5.0

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Youhana Sheriff <youhanasheriff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Dev notice fallback page shows incorrect path (apps/web instead of src/web)

3 participants