Fix MSVC compilation warnings with mbedTLS#3617
Closed
saghul wants to merge 2 commits into
Closed
Conversation
saghul
commented
Jun 19, 2026
saghul
commented
Contributor
- mbedtls: cast sockfd to int when storing in net_context fd
- cmake: honor DISABLE_WERROR on MSVC
The mbedtls server and client bio setup assigned lws_sockfd_type directly to mbedtls_net_context.fd, which is an int. On Win64 lws_sockfd_type is SOCKET (a 64-bit UINT_PTR), so MSVC warns C4244 "possible loss of data", which fails the build under /WX. Add an explicit (int) cast, matching the gnutls and openhitls backends which already cast the same sockfd the same way.
DISABLE_WERROR only gated the GCC/Clang -Werror flag; the MSVC branch added /WX unconditionally, so setting DISABLE_WERROR=ON had no effect when building with MSVC. Gate /WX on DISABLE_WERROR the same way the GCC/Clang path does, leaving /W3 (the warning level) always enabled.
Contributor
Author
|
Landed in main. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.