Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/common/task_utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,15 @@ func TestAugmentArgsForTask_IdleOnCompletePrecedence(t *testing.T) {
opts: TaskAugmentOptions{},
expected: []string{"agent", "run", "--idle-on-complete"},
},
{
name: "does not forward --conversation even when AgentConversationID is set; the embedded warp CLI reads it off task metadata",
task: &types.Task{
AgentConfigSnapshot: &types.AmbientAgentConfig{},
AgentConversationID: strPtr("abc-123"),
},
opts: TaskAugmentOptions{},
expected: []string{"agent", "run", "--idle-on-complete"},
},
{
name: "skips --share public when public_access is nil",
task: &types.Task{
Expand Down
3 changes: 1 addition & 2 deletions internal/types/messages.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ type TaskAssignmentMessage struct {
EnvVars map[string]string `json:"env_vars,omitempty"`
// AdditionalSidecars is a list of extra sidecar images to mount into the task container.
AdditionalSidecars []SidecarMount `json:"additional_sidecars,omitempty"`
// ConversationID is the UUID of an existing AI conversation to continue.
ConversationID string `json:"conversation_id,omitempty"`
}

// TaskClaimedMessage is sent from worker to server after successfully claiming a task
Expand Down Expand Up @@ -132,4 +130,5 @@ type Task struct {
CreatedAt time.Time `json:"created_at"`
UpdatedAt time.Time `json:"updated_at"`
AgentConfigSnapshot *AmbientAgentConfig `json:"agent_config_snapshot,omitempty"`
AgentConversationID *string `json:"agent_conversation_id,omitempty"`
}
3 changes: 0 additions & 3 deletions internal/worker/worker.go
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,6 @@ func (w *Worker) prepareTaskParams(assignment *types.TaskAssignmentMessage) *Tas
"--server-root-url",
w.config.ServerRootURL,
}
if assignment.ConversationID != "" {
baseArgs = append(baseArgs, "--conversation", assignment.ConversationID)
}
baseArgs = common.AugmentArgsForTask(task, baseArgs, common.TaskAugmentOptions{
IdleOnComplete: w.config.IdleOnComplete,
})
Expand Down
Loading