In-app notifications for child agents#10111
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR routes child agent conversations through the HOA notification mailbox/toast pipeline and resolves navigation to either the child pane or parent pane.
Concerns
- Child conversations now bypass
should_exclude_from_navigation()before checkingFeatureFlag::HOANotifications, so with the flag disabled they can fall into the legacy notification path instead of preserving the previous behavior.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| if updated_conversation.should_exclude_from_navigation() | ||
| && !updated_conversation.is_child_agent_conversation() | ||
| { |
There was a problem hiding this comment.
HOANotifications is disabled. Keep the child-agent exception behind the same flag so disabling HOA notifications preserves the old filtering behavior.
| if updated_conversation.should_exclude_from_navigation() | |
| && !updated_conversation.is_child_agent_conversation() | |
| { | |
| if updated_conversation.should_exclude_from_navigation() | |
| && !(FeatureFlag::HOANotifications.is_enabled() | |
| && updated_conversation.is_child_agent_conversation()) | |
| { |

Description
Child agents (local and cloud) currently never trigger in-app notifications because
AgentNotificationsModelfilters them out early viashould_exclude_from_navigation(). This PR allows child agent conversations through the notification pipeline so users get toast/mailbox notifications when a child agent completes, fails, or needs attention.Clicking a child notification navigates to the child's pane if it's been revealed, otherwise to the parent's pane. Gated behind the existing
FeatureFlag::HOANotifications.Oz conversation · Plan
Linked Issue
ready-to-specorready-to-implement.Testing
https://www.loom.com/share/7bf1a8fe8e624b4c8551880b1ea7043f
Agent Mode
Co-Authored-By: Oz oz-agent@warp.dev