Add tab context metadata copy actions#10120
Merged
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
Adjust copy metadata menu items to reflect horizontal tabs, vertical tab grouping, and vertical pane grouping. Add integration coverage for pane-grouped vertical tabs and update the specs. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
Adds layout-aware copy actions for tab and vertical-tabs context menus, with integration coverage for horizontal tab, vertical tab, and vertical pane modes.
Concerns
- Pane-mode row context menus copy metadata from the focused pane rather than the clicked pane, so right-clicking a non-focused pane row can copy the wrong title, branch, and working directory.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Use the clicked pane row as the metadata source when vertical tabs are grouped by panes, falling back to the focused pane only when there is no valid clicked-pane target. Update the integration coverage to right-click a non-focused pane row so the regression fails before the fix and passes after. Co-Authored-By: Oz <oz-agent@warp.dev>
zachbai
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds copy actions to the attached tab context menu so users can copy tab/session metadata directly from the same UI surface where that metadata is shown.
The menu now includes copy actions for available, non-empty metadata when it makes sense for the current tab layout:
Copy tab titleonly, matching the metadata visible in the horizontal tab strip.Copy pane titleinstead ofCopy tab title.All new copy actions use sentence casing, and unavailable metadata is omitted from the menu rather than shown disabled.
Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
Testing
Added integration coverage for the main layout variants:
test_tab_context_menu_copies_metadatacovers horizontal tabs. It verifies that only the tab title copy action is present, and that selecting it copies the tab title.test_vertical_tab_context_menu_copies_metadatacovers vertical tabs grouped by tabs. It verifies that the context menu can copy the branch, tab title, and working directory for the tab/focused session.test_vertical_pane_context_menu_copies_metadatacovers vertical tabs grouped by panes. It creates a split pane with different metadata and verifies that the menu copies the active pane branch, pane title, and working directory.Validation run:
./script/run(bundled and launched WarpLocal.app)./script/run(bundled and launched WarpLocal.app)PATH=/tmp/warp-corepack-bin:$PATH /Users/zach/Projects/warp_3/target/debug/integration test_tab_context_menu_copies_metadataPATH=/tmp/warp-corepack-bin:$PATH /Users/zach/Projects/warp_3/target/debug/integration test_vertical_tab_context_menu_copies_metadataPATH=/tmp/warp-corepack-bin:$PATH /Users/zach/Projects/warp_3/target/debug/integration test_vertical_pane_context_menu_copies_metadatacargo fmt --manifest-path /Users/zach/Projects/warp_3/Cargo.toml --all --checkPATH=/tmp/warp-corepack-bin:$PATH cargo nextest run --manifest-path /Users/zach/Projects/warp_3/Cargo.toml --no-fail-fast --workspace test_tab_context_menu_copies_metadata test_vertical_tab_context_menu_copies_metadata test_vertical_pane_context_menu_copies_metadataPATH=/tmp/warp-corepack-bin:$PATH cargo clippy --manifest-path /Users/zach/Projects/warp_3/Cargo.toml --workspace --all-targets --all-features --tests -- -D warningsNote: initial nextest/clippy attempts without temporary Corepack shims failed in
command-signatures-v2because the global Yarn version is 1.22.22 while that crate requires Corepack/Yarn 4.0.1. Rerunning with temporary Corepack shims passed.Agent Mode
CHANGELOG-IMPROVEMENT: Added tab context menu actions to copy visible tab and pane metadata when available.
Co-Authored-By: Oz oz-agent@warp.dev