Open
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR moves shared agent skills out of the Warp repo and adds bootstrap/run integration that installs or refreshes them from the pinned common-skills lock.
Concerns
- The local common-skills source path bypasses the documented ref override, so a caller can request one ref and silently install/stamp another.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Oz <oz-agent@warp.dev>
901ca39 to
3df1e8c
Compare
Co-Authored-By: Oz <oz-agent@warp.dev>
# Conflicts: # script/macos/bootstrap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an opt-in installer for shared agent skills from
warpdotdev/common-skillswithout changing the default bootstrap or run behavior.This PR:
.agents/common-skills.lockto pin the common-skills source revision.script/install_common_skills, which installs skills into a selected.agents/skillsdestination and writes a stamp so unchanged versions are skipped../script/bootstrap --install-common-skills./script/run --install-common-skills.\script\windows\bootstrap.ps1 -InstallCommonSkillswarp_sudostep..agents/skillscopies in place for a safe rollout.Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
Not applicable; script-only change.
Testing
bash -n script/install_common_skillsbash -n script/bootstrapbash -n script/runscript/windows/bootstrap.ps1./script/bootstrap --help./script/install_common_skills --helpgit diff --checkcargo fmt --all --manifest-path Cargo.tomlcargo clippy --manifest-path Cargo.toml --workspace --all-targets --all-features --tests -- -D warningsAgent Mode
Co-Authored-By: Oz oz-agent@warp.dev