Enable IME marked text on Windows and Linux#10122
Enable IME marked text on Windows and Linux#10122rikarazome wants to merge 2 commits intowarpdotdev:masterfrom
Conversation
Remove the macOS-only cfg guard on ImeMarkedText in RELEASE_FLAGS. The implementation (event handling, grid rendering, editor support) is already platform-agnostic and has been active in dogfood builds on all platforms. Fixes warpdotdev#7987 Fixes warpdotdev#3403 Related: warpdotdev#6891 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Two changes to enable inline IME composition (preedit) text display on all platforms: 1. Remove the macOS-only cfg guard on ImeMarkedText in RELEASE_FLAGS so release builds enable the flag on Windows and Linux. 2. Add ime_marked_text to the gui cargo feature so OSS/local builds also get IME support by default. The underlying implementation (winit event handling, grid renderer, editor marked text support) is already platform-agnostic and has been validated in dogfood builds on all platforms. Tested locally on Windows with Japanese IME - preedit text now displays inline with underline decoration during composition. Fixes warpdotdev#7987 Fixes warpdotdev#3403 Related: warpdotdev#6891 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @rikarazome on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR enables the existing IME marked-text feature for release builds on Windows/Linux and includes the Cargo ime_marked_text feature in GUI builds.
Concerns
- This is user-visible IME composition rendering behavior, but the PR description does not include screenshots or a video demonstrating the feature working end to end. For faster review, please upload screenshots or a video of the feature working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
ScreenshotsIME composition text working on Windows 11
Preedit text (「てすとてすて」) is displayed inline with underline decoration at the cursor position. The IME candidate window appears and text commits correctly after selection. Note: The IME candidate window positioning could be improved (it overlaps the input area when the cursor is near the bottom of the terminal), but that is a pre-existing issue in @cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
C:/Program Files/Git/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
oz-for-oss
Bot
dismissed
their stale review
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
This PR enables the existing IME marked-text feature for Windows and Linux release builds and includes it in the GUI cargo feature for OSS/local graphical builds. The changed gates align with the platform-agnostic marked-text handling already present in the editor and terminal paths.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
oz-for-oss
Bot
requested review from
a team and
kevinchevalier
and removed request for
a team
1 participant
Summary
#[cfg(target_os = "macos")]guard onImeMarkedTextinRELEASE_FLAGS, enabling it for Windows and Linux release buildsime_marked_textto theguicargo feature so OSS/local builds also get IME composition text display by defaultContext
The IME preedit (composition) text implementation is already fully platform-agnostic:
winitIME event handling dispatchesSetMarkedText/ClearMarkedTexton all platformsgrid_rendererdraws marked text inline with underline decorationDOGFOOD_FLAGSThe only thing preventing it from working in release builds on Windows/Linux was the feature flag gate.
Test plan
Fixes #7987
Fixes #3403
Related: #6891