Skip to content

Fix tail path in script/macos/run --open_with_launchd for OSS channel #10140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebryu wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −1
Open

Fix tail path in script/macos/run --open_with_launchd for OSS channel #10140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac1924e
Fix tail path in script/macos/run --open_with_launchd for OSS channel.
sebryu May 5, 2026
679b8cb
Make WARP_CHANNEL log-path mapping explicit in script/macos/run.
sebryu May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion script/macos/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,15 @@ if [ "$DONT_OPEN" = false ] ; then
if [ "$OPEN_WITH_LAUNCHD" = true ]; then
echo "Launching with MacOS application launcher"
PATH="" /usr/bin/open "./$WARP_APP_PATH"
tail -f ~/Library/Logs/warp_local.log
if [ "$WARP_CHANNEL" = "local" ]; then
LOG_FILE=~/Library/Logs/warp_local.log
elif [ "$WARP_CHANNEL" = "oss" ]; then
LOG_FILE=~/Library/Logs/warp-oss.log
else
Copy link
Copy Markdown
Contributor

@peicodes peicodes May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we elif here and be specific about the OSS channel, and in the else case log a warning that the channel is unrecognized

Copy link
Copy Markdown
Contributor Author

@sebryu sebryu May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 679b8cb — added an explicit elif for oss and a warning on unrecognized channels.

echo "Warning: unrecognized WARP_CHANNEL '$WARP_CHANNEL', defaulting to OSS log path" >&2
LOG_FILE=~/Library/Logs/warp-oss.log
fi
tail -F "$LOG_FILE"
else
echo "Opening app at ./$WARP_APP_PATH/Contents/MacOS/$WARP_BIN_NAME"
"./$WARP_APP_PATH/Contents/MacOS/$WARP_BIN_NAME" "${WARP_ARGS[@]}"
Expand Down