Migrate conversation list to AgentConversationEntry#10197
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
| AgentRunDisplayStatus::TaskQueued | ||
| | AgentRunDisplayStatus::TaskPending | ||
| | AgentRunDisplayStatus::TaskClaimed | ||
| | AgentRunDisplayStatus::TaskInProgress |
There was a problem hiding this comment.
is there a difference between task in progress and conversation in progress? I know the source is different, but wondering if at the abstraction layer they should be the same thing (and then same question for the other overlapping statuses)
There was a problem hiding this comment.
added some comments to distinguihs
| } | ||
|
|
||
| pub fn resolve_open_action( | ||
| subject: AgentConversationNavigationSubject, |
There was a problem hiding this comment.
it might be worth a comment on the difference between resolve_open_action and resolve_entry_open_action, and/or I guess the general difference between an entry and a subject
There was a problem hiding this comment.
It took me a sec to grok the distinction in both cases
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR migrates the conversation list rendering and navigation path to use AgentConversationEntry instead of direct ConversationOrTask lookups.
Concerns
- The new
agent_conversation_entry_icon_variantpath ignoresentry.display.harnessfor non-ambient local/cloud entries, so non-Oz conversations can regress to the Oz icon in the conversation list. - This changes user-visible conversation list icons, row behavior, and menu behavior, but the PR does not include screenshots or video. For faster review, please upload screenshots or a video of the feature working end to end.
Verdict
Found: 0 critical, 1 important, 1 suggestion
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| is_ambient, | ||
| ) | ||
| } else { | ||
| IconWithStatusVariant::OzAgent { |
There was a problem hiding this comment.
entry.display.harness; non-Oz conversations such as Claude/Codex will regress from their agent icon to Oz.
zachbai
force-pushed
the
zb/agent-conversation-entry
branch
from
b6a5b47 to
ab1fa14
Compare
zachbai
force-pushed
the
zb/migrate-list-view
branch
from
093ac2a to
9f13cec
Compare
zachbai
force-pushed
the
zb/migrate-list-view
branch
from
9f13cec to
4f69792
Compare
2 participants
Description
Migrates the conversation list UI/model plumbing to consume the new
AgentConversationEntryabstraction introduced downstack.This keeps active agent, conversation, and task entries represented through a shared entry layer so the list view can rely on entry-provided labels, icons, timestamps, and selection state instead of duplicating that logic in the view model.
Linked Issue
None.
Screenshots / Videos
Not included; refactor of existing conversation list behavior.
Testing
cargo fmt --checkcargo clippy --workspace --all-targets --all-features --tests -- -D warningsat user request.Agent Mode
Co-Authored-By: Oz oz-agent@warp.dev:wq