Use the public claude platform plugin. by liliwilson · Pull Request #12879 · warpdotdev/warp

liliwilson · 2026-06-21T15:53:58Z

Description

After we update claude-code-warp to include the platform plugin for multi-harness runs, we need to update the driver to pull that version of the plugin in: warpdotdev/claude-code-warp#69.

I also noticed that the minimum plugin version asserted in this repo was too high given the version we have set in claude-code-warp-internal, meaning that the platform will always fail to start the driver since it tries to update to a version that doesn't exist.

Testing

I will test with oz-local once the other PR lands.

oz-for-oss · 2026-06-21T15:59:23Z

@liliwilson

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss

Overview

This PR moves the Claude platform plugin marketplace from the internal repository to the public warpdotdev/claude-code-warp repository and lowers the asserted minimum platform plugin version.

Concerns

Removing PLATFORM_MARKETPLACE_REPO breaks the remaining unchanged update_platform_plugin call site, so the Rust code will not compile until that call site is updated or the constant is kept.
No approved or repository spec context was available, so there were no spec-alignment commitments to validate.

Verdict

Found: 1 critical, 0 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

oz-for-oss · 2026-06-21T16:01:24Z


-const PLATFORM_PLUGIN_KEY: &str = "oz-harness-support@claude-code-warp";
-// Note: we will eventually publish this to the same marketplace repo, but are using the internal one as we build out multi-harness.
-const PLATFORM_MARKETPLACE_REPO: &str = "warpdotdev/claude-code-warp-internal";


🚨 [CRITICAL] Deleting this constant leaves the unchanged update_platform_plugin method referencing PLATFORM_MARKETPLACE_REPO, so the crate will fail to compile; update that call site to MARKETPLACE_REPO too or keep the constant.

seems important

vorporeal · 2026-06-21T16:07:08Z

-// Keep in sync with the oz-harness-support plugin version in warpdotdev/claude-code-warp-internal.
-const MINIMUM_PLATFORM_PLUGIN_VERSION: &str = "1.1.3";
+// Keep in sync with the oz-harness-support plugin version in warpdotdev/claude-code-warp.
+const MINIMUM_PLATFORM_PLUGIN_VERSION: &str = "1.1.2";


Is this something we should have some sort of automated test for?

Yeah 100%. It shouldn't be hard to - we should check that this value matches:
https://github.com/warpdotdev/claude-code-warp/blob/58c823da195346a7e6645fd2d9484d0e38db6bc2/.claude-plugin/marketplace.json#L21
and
https://github.com/warpdotdev/claude-code-warp/blob/58c823da195346a7e6645fd2d9484d0e38db6bc2/plugins/oz-harness-support/.claude-plugin/plugin.json#L4

(same for the non-platform plugin)

vorporeal · 2026-06-21T16:07:35Z


-const PLATFORM_PLUGIN_KEY: &str = "oz-harness-support@claude-code-warp";
-// Note: we will eventually publish this to the same marketplace repo, but are using the internal one as we build out multi-harness.
-const PLATFORM_MARKETPLACE_REPO: &str = "warpdotdev/claude-code-warp-internal";


seems important

cla-bot · 2026-06-21T16:14:42Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2026-06-21T16:15:20Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2026-06-21T16:15:46Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot · 2026-06-21T22:41:27Z

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lili Wilson.
This is most likely caused by a git client misconfiguration; please make sure to:

check if your git client is configured with an email to sign commits git config --list | grep email
If not, set it up using git config --global user.email email@example.com
Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

## Description  After we update `claude-code-warp` to include the platform plugin for multi-harness runs, we need to update the driver to pull that version of the plugin in: warpdotdev/claude-code-warp#69. I also noticed that the minimum plugin version asserted in this repo was too high given the version we have set in `claude-code-warp-internal`, meaning that the platform will always fail to start the driver since it tries to update to a version that doesn't exist. ## Testing  I will test with `oz-local` once the other PR lands. --------- Co-authored-by: Oz <oz-agent@warp.dev>

cla-bot Bot added the cla-signed label Jun 21, 2026

liliwilson force-pushed the lili/use-public-claude-plugin branch from 1bf5610 to de650a3 Compare June 21, 2026 15:54

liliwilson marked this pull request as ready for review June 21, 2026 15:59

liliwilson requested review from abhishekp106 and vorporeal June 21, 2026 15:59

oz-for-oss Bot reviewed Jun 21, 2026

View reviewed changes

vorporeal approved these changes Jun 21, 2026

View reviewed changes

cla-bot Bot removed the cla-signed label Jun 21, 2026

oz-agent and others added 5 commits June 21, 2026 18:39

Use the public claude plugin

8ecf609

Also fix to use the actual version

a3f2b41

Compilation

dca8462

ci

99e96ae

ci

8f2d6ee

liliwilson force-pushed the lili/use-public-claude-plugin branch from c7b4c82 to 3aac552 Compare June 21, 2026 22:41

liliwilson force-pushed the lili/use-public-claude-plugin branch from 3aac552 to 8f2d6ee Compare June 21, 2026 22:43

cla-bot Bot added the cla-signed label Jun 21, 2026

liliwilson added 2 commits June 22, 2026 10:48

Update the HOME dir used

0daad5e

fix failing tests

e2c4cdc

liliwilson force-pushed the lili/use-public-claude-plugin branch from 9f62f73 to e2c4cdc Compare June 22, 2026 15:16

liliwilson merged commit 71d95da into master Jun 22, 2026
25 checks passed

liliwilson deleted the lili/use-public-claude-plugin branch June 22, 2026 15:43

Uh oh!

Conversation

liliwilson commented Jun 21, 2026

Description

Testing

Uh oh!

oz-for-oss Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oz-for-oss Bot left a comment

Choose a reason for hiding this comment

Overview

Concerns

Verdict

Uh oh!

oz-for-oss Bot Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

vorporeal Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

liliwilson Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

vorporeal Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

liliwilson Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

vorporeal Jun 21, 2026

Choose a reason for hiding this comment

Uh oh!

cla-bot Bot commented Jun 21, 2026

Uh oh!

cla-bot Bot commented Jun 21, 2026

Uh oh!

cla-bot Bot commented Jun 21, 2026

Uh oh!

cla-bot Bot commented Jun 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oz-for-oss Bot commented Jun 21, 2026 •

edited

Loading