WIP: performance optimizations#13667
Draft
KRRT7 wants to merge 5 commits into
Draft
Conversation
Rework flat-storage indexing and replay around faster row paths. - Add arithmetic rebuild fast paths for uniform rows, carry-over rows, and wide-character spacer cases. - Preserve EntryBuilder capacity across flushes and add dense single-width row replay. - Harden truncate and cursor-offset edge cases used by resize. - Add differential/property tests, a fuzz target, and rebuild benchmark coverage.
Optimize repeated fuzzy/file-search work and input edit checks. - Add ASCII fast paths for wildcard matching, session/search columns, and remote result columns. - Reuse parsed fuzzy path query metadata instead of re-scanning wildcard state per candidate. - Avoid repeated editor buffer reads while handling input edits and AI context checks. - Fix multibyte @ context handling and navigation query heuristics with targeted coverage.
Reduce repeated model and layout work in the terminal block list. - Skip live block-height SumTree rewrites when the computed height is unchanged. - Update rich-content heights by targeted SumTree item replacement instead of a full rebuild. - Track rich-content and CLI subagent children laid out in the current frame so after_layout only visits active children. - Add model coverage for mixed rich-content/banner positions and unchanged height updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Performance optimization stack focused on terminal hot paths:
Latest VM benchmark summary after
cargo clean, comparingupstream/masterb43821d0against brancha2c2a9e1with representative flat-storage rebuild workloads:p < 0.05.Linked Issue
ready-to-specorready-to-implement.Testing
cargo fmt --allenv -u RUSTC_WRAPPER cargo nextest run -p warp -E 'test(test_gap_after_banner) | test(test_removed_gap_with_banner) | test(test_update_padding_block_heights) | test(test_remove_rich_content_block) | test(test_update_rich_content_heights_in_lines_updates_changed_items_by_position)'git diff --check upstream/master..HEADflat_storagerebuild harness,upstream/masterb43821d0vs brancha2c2a9e1; artifacts in/root/warp/target/criterion/flat_storage_representative_*.Not yet run: full
./script/presubmit/ full workspace clippy../script/runScreenshots / Videos
Not applicable: internal performance changes with benchmark coverage.
Agent Mode
CHANGELOG-NONE