Allow cloud environments without Docker images#13674
Draft
warp-dev-github-integration[bot] wants to merge 1 commit into
Draft
Allow cloud environments without Docker images#13674warp-dev-github-integration[bot] wants to merge 1 commit into
warp-dev-github-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cloud environments stored without a
docker_imagecurrently fail to deserialize because the flattenedBaseImageenum is required. This change models the flattened base image as optional so older or platform-specific environments without a pinned image load successfully.Environments with a Docker image retain the exact existing wire shape (
"docker_image": "..."). Environments without one deserialize toNone, reserialize without the key, and omit image-only UI and CLI details.This branch is based directly on
86dfca99cf45945233f72b25b100998856f29ec5.Linked Issue
ready-to-specorready-to-implement.No linked issue.
Testing
Added unit coverage for deserializing a missing
docker_image, round-tripping an absent image without emitting the field, and preserving the exact flattened JSON shape for a present image../script/formatcargo test -p cloud_object_modelscargo clippy -p cloud_object_models --all-targets --all-features --tests -- -D warningscargo check -p warp --libI have manually tested my changes locally with
./script/runAgent Mode
CHANGELOG-BUG-FIX: Fixed cloud environments without a pinned Docker image failing to load.
Co-Authored-By: Oz oz-agent@warp.dev
Conversation: https://staging.warp.dev/conversation/9a89c4f9-71c2-45e2-8b28-1c98c25c108b
Run: https://oz.staging.warp.dev/runs/019f5d58-f791-7679-9529-491a87f3d1b5
This PR was generated with Oz.