Fix question mark handling in queued prompt editor#13686
Draft
warp-dev-github-integration[bot] wants to merge 1 commit into
Draft
Fix question mark handling in queued prompt editor#13686warp-dev-github-integration[bot] wants to merge 1 commit into
warp-dev-github-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents the Agent View
shift-?help shortcut from intercepting?while a queued prompt is being edited. The binding now excludes the existing queued-prompt inline-editor context, allowing the focused editor to receive the character normally.This comparison is intentionally based on the parent of the previously landed fix, per the task requirements; the existing fix implementation and PR were not inspected.
Linked Issue
N/A.
Testing
Added
question_mark_edits_queued_prompt_instead_of_opening_agent_help, which exercises the real keymap responder chain, verifies help remains closed, and confirms the queued prompt becomesWhy?.CARGO_BUILD_JOBS=1 cargo nextest run -p warp -E 'test(question_mark_edits_queued_prompt_instead_of_opening_agent_help) | test(redetermine_terminal_focus_preserves_focused_queued_prompt_editor)'— 2 passed.CARGO_BUILD_JOBS=1 cargo clippy -p warp --lib --tests -- -D warnings— passed../script/format --check— passed.git diff --check— passed.I have manually tested my changes locally with
./script/runAgent Mode
CHANGELOG-BUG-FIX: Fixed
?opening Agent View help while editing a queued prompt.Conversation: https://staging.warp.dev/conversation/18c06931-0c57-4b75-987f-9626f8200b44
Run: https://oz.staging.warp.dev/runs/019f5d5b-1792-75f6-bf6f-062139d70d06
Plans:
Co-Authored-By: Oz oz-agent@warp.dev
This PR was generated with Oz.