Drop Pty Spawned telemetry emission#13687
Open
kelmanchiang wants to merge 1 commit into
Open
Conversation
Remove PtySpawned telemetry from PTY spawn paths and drop the now-unneeded AppContext argument from PtySpawner::spawn_pty callsites. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR removes TelemetryEvent::PtySpawned emission from PTY spawn paths and drops the now-unused AppContext plumbing from the Unix and Windows call sites.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the annotated diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split from #13554 to only remove the
Pty Spawnedtelemetry emission. This change removesTelemetryEvent::PtySpawnedsends in PTY spawn paths and removes the now-unneededAppContextargument plumbing forPtySpawner::spawn_ptycall sites.Linked Issue
N/A (split-out follow-up from #13554)
ready-to-specorready-to-implement.Testing
./script/run./script/formatcargo clippy --workspace --all-targets --all-features --tests -- -D warnings(fails in this environment:xcrun: error: unable to find utility "metal")Screenshots / Videos
Not applicable (no user-visible UI change).
Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev