Add TUI model selector#13690
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| pub(crate) max_visible_rows: usize, | ||
| pub(crate) status: Option<TuiInlineMenuStatus>, | ||
| } | ||
| /// Reusable list mechanics shared by the slash-command, conversation, and model menus. |
There was a problem hiding this comment.
pulled out to be shared among slash command menu, conversation menu, and model menu
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds a searchable /model picker for the headless TUI, shares the existing model-picker ordering/filtering policy, routes model selection through the generalized inline-menu handle, and persists the accepted model through AISettings.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the annotated diff. The attached spec context contains no approved requirements, and the PR description includes a Loom link as visual evidence for this TUI-facing change.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1 participant
Description
Stacked on #13662.
Adds a searchable
/modelpicker to the headless TUI. The change reuses the shared model-query policy, generalizes inline-menu routing behind a trait-object handle, supports filtering and disabled choices, and persists the accepted agent model throughAISettings.Linked Issue
ready-to-specorready-to-implement.No linked issue was provided.
Testing
https://www.loom.com/share/7c6476f23f8c44d4b414de2c8c11911a
./script/formatcargo test -p warp_tui --lib --no-runcargo nextest run -p warp_tui— 166 passed/modelclassification — 2 passedcargo clippy -p warp_tui --all-targets --all-features --tests -- -D warningscargo clippy -p warp --lib --tests -- -D warningsCARGO_BUILD_JOBS=2 cargo build -p warp_tui --bin warp-tui./script/presubmitand integration tests — skipped at reviewer request/modelsmoke test — interactive run was canceled./script/run-tuiThe broader all-features workspace Clippy invocation is currently blocked by unrelated dead-code errors in terminal sharing and remote-server code; the affected packages pass strict Clippy.
Screenshots / Videos
Not captured because the interactive TUI smoke test was canceled.
Agent Mode
CHANGELOG-IMPROVEMENT: Added searchable model selection to the headless TUI.
Co-Authored-By: Oz oz-agent@warp.dev