Add agent_identity_uid support for remote child agent execution#13773
Add agent_identity_uid support for remote child agent execution#13773dagmfactory wants to merge 6 commits into
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates the remote child-agent launch path to carry agent_identity_uid from run_agents configs through StartAgentExecutionMode::Remote into SpawnAgentRequest, rejects non-empty identities for local execution, and adds focused tests for remote propagation and local rejection. The implementation otherwise aligns with the PR description, and no approved repository spec context was available for additional spec-drift checks.
Concerns
- The PR includes a generated
review.jsonfile in the repository diff. That file is review workflow output and should be uploaded as an artifact, not committed alongside the product changes.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
…-sibling # Conflicts: # Cargo.lock # Cargo.toml
…o dagm/agent-run-from-sibling
…ntRunConfig) Co-Authored-By: Oz <oz-agent@warp.dev>
…26f16) Co-Authored-By: Oz <oz-agent@warp.dev>
This PR adds support for
agent_identity_uidto allow factory agents to dispatch child agents under a specific named-agent identity (service account).Key changes include:
warp_multi_agent_apito the latest proto revision to include the new field.agent_identity_uidtoRunAgentsAgentRunConfigandStartAgentExecutionMode::Remote.run-agentstostart-agentpipeline, ensuring it is correctly passed toSpawnAgentRequest.agent_identity_uidis only used for remote execution; local child agents will now return an error if this field is provided.