Skip to content

Add agent_identity_uid support for remote child agent execution#13773

Open
dagmfactory wants to merge 6 commits into
masterfrom
dagm/agent-run-from-sibling
Open

Add agent_identity_uid support for remote child agent execution#13773
dagmfactory wants to merge 6 commits into
masterfrom
dagm/agent-run-from-sibling

Conversation

@dagmfactory

Copy link
Copy Markdown
Contributor

This PR adds support for agent_identity_uid to allow factory agents to dispatch child agents under a specific named-agent identity (service account).

Key changes include:

  • Updated warp_multi_agent_api to the latest proto revision to include the new field.
  • Added agent_identity_uid to RunAgentsAgentRunConfig and StartAgentExecutionMode::Remote.
  • Threaded the identity through the run-agents to start-agent pipeline, ensuring it is correctly passed to SpawnAgentRequest.
  • Added validation to ensure agent_identity_uid is only used for remote execution; local child agents will now return an error if this field is provided.
  • Included comprehensive tests to verify successful propagation for remote agents and proper rejection for local ones.

@cla-bot cla-bot Bot added the cla-signed label Jul 15, 2026
@oz-for-oss

oz-for-oss Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@dagmfactory

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates the remote child-agent launch path to carry agent_identity_uid from run_agents configs through StartAgentExecutionMode::Remote into SpawnAgentRequest, rejects non-empty identities for local execution, and adds focused tests for remote propagation and local rejection. The implementation otherwise aligns with the PR description, and no approved repository spec context was available for additional spec-drift checks.

Concerns

  • The PR includes a generated review.json file in the repository diff. That file is review workflow output and should be uploaded as an artifact, not committed alongside the product changes.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@warpdotdev warpdotdev deleted a comment from oz-for-oss Bot Jul 16, 2026
dagmfactory and others added 2 commits July 16, 2026 17:39
…ntRunConfig)

Co-Authored-By: Oz <oz-agent@warp.dev>
…26f16)

Co-Authored-By: Oz <oz-agent@warp.dev>
@dagmfactory
dagmfactory enabled auto-merge (squash) July 16, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants