Add bottom padding below TUI footer/prompt (CODE-1878)#13850
Open
warp-dev-github-integration[bot] wants to merge 1 commit into
Open
Add bottom padding below TUI footer/prompt (CODE-1878)#13850warp-dev-github-integration[bot] wants to merge 1 commit into
warp-dev-github-integration[bot] wants to merge 1 commit into
Conversation
The headless TUI's terminal-session root container had top/horizontal padding but no bottom padding, so the footer/prompt rendered flush against the bottom terminal edge. Commit 28f2553 added `.with_padding_top(2)` without a matching bottom pad. Wrap the view root with `.with_padding_bottom(1)` (extracted into a small `wrap_view_root_padding` helper) so one blank row renders below the footer, matching the Figma spec (~1 cell row of whitespace below the footer). Add a render-to-lines unit test asserting the trailing blank padding row. Fixes CODE-1878 CHANGELOG-BUG-FIX: Fixed the headless TUI footer/prompt rendering flush against the bottom terminal edge with no padding. Co-Authored-By: Oz <oz-agent@warp.dev>
| assert_eq!(actual_update.new_size().columns(), 42); | ||
| } | ||
|
|
||
| fn render_lines_sized( |
Member
There was a problem hiding this comment.
I don't think we need these test cases
| .with_padding_x(2) | ||
| .with_padding_top(2) | ||
| .finish() | ||
| wrap_view_root_padding(terminal_content.finish()).finish() |
Member
|
@oz-agent address these comments and fix CI |
Member
|
@warp-agent are you the right one to trigger here |
Contributor
|
You can view the conversation on Warp. Powered by Oz |
Member
|
@warp-agent try again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The headless TUI's terminal-session root container (
TuiTerminalSessionView::render) had horizontal and top padding but no bottom padding, so the footer/prompt rendered flush against the bottom terminal edge. Commit28f25535f8("Proper long running command rendering", #13774) added.with_padding_top(2)without a matching bottom pad.This adds
.with_padding_bottom(1)to the view root (extracted into a smallwrap_view_root_paddinghelper so it's unit-testable), giving one blank row of whitespace below the footer/prompt — matching the Figma spec (frame323:17499, ~12px ≈ 1 cell row of whitespace below the footer).Linked Issue
Fixes CODE-1878 — https://linear.app/warpdotdev/issue/CODE-1878
Testing
view_root_pads_a_blank_row_below_the_footer) asserting the trailing blank padding row below the footer.cargo test -p warp_tui --lib→ 277 passed. (cargo fmt+cargo clippy -p warp_tui --all-targets --tests -- -D warningsclean.)warp-tui-devbuild under tmux (120x40), pertui-verify-change. Before: footer on the last terminal row (row 40, flush). After: footer on row 39 with a blank padding row 40.Screenshots / Videos
Captured
tmux capture-paneframes (attached as a run artifact):Before (footer flush to bottom edge):
After (one blank padding row below the footer):
Agent Mode
CHANGELOG-BUG-FIX: Fixed the headless TUI footer/prompt rendering flush against the bottom terminal edge with no padding.
Conversation: https://staging.warp.dev/conversation/7817fa6c-ef0d-4f52-b27a-08aeb9673dec
Run: https://oz.staging.warp.dev/runs/019f6ca8-67ba-7588-b055-70f5ba1ea4ed
This PR was generated with Oz.