Skip to content

Demote non-actionable report_error! calls in terminal/view.rs #13857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
warp-dev-github-integration wants to merge 3 commits into
base: master
Choose a base branch
from
+14 −14
Open

Demote non-actionable report_error! calls in terminal/view.rs #13857

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a971ccb
Demote non-actionable report_error! calls in terminal/view.rs
warp-agent Jul 16, 2026
7e042ea
Address review feedback: drop explanatory comments
warp-agent Jul 16, 2026
10cd181
Use log::error! for end_selection invariant violation
warp-agent Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions app/src/terminal/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5895,9 +5895,9 @@ impl TerminalView {
agent_view_visibility: agent_view_visibility.into(),
},
) {
report_error!(anyhow::Error::new(e).context(
"Error sending UpdateBlockAgentViewVisibility event"
));
log::warn!(
"Error sending UpdateBlockAgentViewVisibility event: {e:#}"
);
}
}
}
Expand Down Expand Up @@ -5930,9 +5930,9 @@ impl TerminalView {
agent_view_visibility: agent_view_visibility.into(),
},
) {
report_error!(anyhow::Error::new(e).context(
"Error sending UpdateBlockAgentViewVisibility event"
));
log::warn!(
"Error sending UpdateBlockAgentViewVisibility event: {e:#}"
);
}
}
}
Expand Down Expand Up @@ -7413,7 +7413,7 @@ impl TerminalView {

// Determine DiffMode from the base branch.
if self.current_repo_path.is_none() {
report_error!("Cannot insert PR comments: not in a git repository");
log::warn!("Cannot insert PR comments: not in a git repository");
return;
}

Expand Down Expand Up @@ -10302,8 +10302,7 @@ impl TerminalView {
agent_view_visibility: agent_view_visibility.into(),
})
{
report_error!(anyhow::Error::new(e)
.context("Error sending UpdateBlockAgentViewVisibility event"));
log::warn!("Error sending UpdateBlockAgentViewVisibility event: {e:#}");
}
}
}
Expand Down Expand Up @@ -12508,8 +12507,9 @@ impl TerminalView {
},
move |_, res, _| {
if let Err(err) = res {
report_error!(anyhow::Error::new(err)
.context("Error sending UpdateFinishedCommand event"));
log::warn!(
"Error sending UpdateFinishedCommand event: {err:#}"
);
}
},
);
Expand Down Expand Up @@ -17940,7 +17940,7 @@ impl TerminalView {
self.maybe_copy_selection_to_clipboard(ctx);
ctx.notify();
} else {
report_error!("end_selection dispatched with no pending selection");
log::error!("end_selection dispatched with no pending selection");
}
}

Expand Down Expand Up @@ -17976,7 +17976,7 @@ impl TerminalView {

ctx.notify();
} else {
report_error!("end_selection dispatched with no pending selection");
log::error!("end_selection dispatched with no pending selection");
}
}

Expand Down Expand Up @@ -25895,7 +25895,7 @@ impl TerminalView {
#[cfg(feature = "local_fs")]
{
let Some(working_directory_str) = self.pwd() else {
report_error!("No working directory found for terminal session");
log::warn!("No working directory found for terminal session");
return;
};

Expand Down
Loading