fix(download-llvm): support tags without 'v' or 'version_' prefix#64
Merged
Conversation
The llvm-project releases are not prefixed with 'v' or 'version' and so we need to relax the check: ``` ❯ wasixccenv download-llvm 21.1.204 error: invalid value '21.1.204' for '[TAG]': Invalid tag specification: `21.1.204`. Use 'latest', a tag starting with 'v', or 'version_XXX'. ``
Contributor
There was a problem hiding this comment.
Pull request overview
Relaxes TagSpec parsing for wasixccenv download-llvm so LLVM release tags that don’t use v/version_ prefixes (e.g. 21.1.204) can be accepted, and updates the validation error message accordingly.
Changes:
- Allow tag strings starting with an ASCII digit to be parsed as
TagSpec::Tag. - Update the invalid-tag error message to mention numeric versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Arshia001
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The llvm-project releases are not prefixed with 'v' or 'version' and so we need to relax the check: