Conversation
daxpedda
force-pushed
the
daxpedda
branch
20 times, most recently
from
9ecf878 to
2604741
Compare
Spxg
reviewed
Mar 17, 2026
daxpedda
force-pushed
the
daxpedda
branch
9 times, most recently
from
b1facb5 to
0e2104b
Compare
Spxg
reviewed
Mar 20, 2026
| " }})", | ||
| " let view", | ||
| "", | ||
| " if (this.#jsEmbed.js_sys['string.sab']) {{", |
Member
There was a problem hiding this comment.
Does this still need to be checked? What is the relationship between this and not(js_sys_target_feature = "sab")
Member
There was a problem hiding this comment.
I think I kind of get it now — with the sab feature enabled, it only works on SharedArrayBuffer, but with the sab feature disabled, it can work on both ArrayBuffer and SharedArrayBuffer?
Member
Author
There was a problem hiding this comment.
The sab feature just assumes that TextDe/Encoder works with SharedArrayBuffer without checking.
Without the sab feature we do a runtime check.
But the sab feature itself has no effect without +atomics because SharedArrayBuffer is not supported without it.
daxpedda
force-pushed
the
daxpedda
branch
10 times, most recently
from
0a308e3 to
ed44d52
Compare
daxpedda
force-pushed
the
daxpedda
branch
4 times, most recently
from
7e78bf7 to
0b9c6f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.