Framework tests: Phase 1 no-DB apps (Total.js CMS, Dashy, Etherpad)#102
Merged
Conversation
Bumps the wasmer-examples submodule to include the new js-totaljs-cms backend-app framework test (Total.js v5 CMS). Green on the framework-test-quickjs-native and framework-test-quickjs-wasix targets (Node baseline + EdgeJS QuickJS native/WASIX). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bumps the wasmer-examples submodule to include the new js-dashy framework test (Dashy dashboard). Green on framework-test-quickjs-native and framework-test-quickjs-wasix (Node baseline + EdgeJS QuickJS native/WASIX), running Dashy's Express server on the built dist output. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bumps wasmer-examples to include the js-etherpad backend-app framework test (Node-side TS->JS build). Adds js-etherpad to FRAMEWORK_TEST_EDGE_SKIP so the Node baseline still validates it while the EdgeJS edge stages are skipped pending fixes: missing Intl constructors on native (Intl.ListFormat, ECO-381) and a runtime-esbuild call on WASIX. The QuickJS GC use-after-frees that previously also blocked it are fixed and merged in #101. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The quickjs workflow pinned Node 22, but the js-etherpad framework-test
Node baseline requires Node >= 24 ("Running Etherpad on Node v22.23.0 is
not supported"), causing all three quickjs matrices to fail. The v8
workflow already runs on the runner default (Node 24) and passes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The quickjs-macos job hangs indefinitely in the framework/standalone tests. The cause is `gatsby build` itself hanging on GitHub macOS runners (a gatsby-worker/sharp issue) during `pnpm run build` — it is the build step, not EdgeJS running the app. The harness only has server-readiness/ request timeouts (which apply while serving), not a build-step timeout, so a hung build hangs the whole job. Linux and WASIX build gatsby fine. Add a FRAMEWORK_TEST_EXCLUDE env that drops projects from discovery entirely (never built, no stage attempted) — stronger than the per-stage FRAMEWORK_TEST_NODE_SKIP/EDGE_SKIP, which still build the app. Set it to js-gatsby-staticsite,js-gatsby-staticsite2 on the macOS job only, so those apps stay covered on Linux and WASIX. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of ECO-355 — the no-DB self-hosted backend apps: brings the first three real stateful Node backend servers under the framework-test harness (previously it only covered static-site / SSR frontends).
Apps added (in the
wasmer-examplessubmodule,edgejsbranch →6b286ae):What's in this PR
wasmer-examples3616ac90 → 6b286ae(the threejs-*app examples + theirroutes.json).js-etherpadtoFRAMEWORK_TEST_EDGE_SKIPfor both the native and WASIX matrices (framework-test + standalone-build). The Node baseline still runs for Etherpad, so its build/boot stays validated.No runtime/
srcchanges — this is purely the harness picking up three new example apps (auto-discovered) plus the Makefile skip entries.Etherpad status (edge-skipped, tracked)
Etherpad boots on Node but the EdgeJS edge stages are parked pending two unrelated, tracked runtime gaps:
Intlconstructors (Intl.ListFormat) — ECO-381.esbuildcall inspecialpages.ts.The QuickJS cycle-GC use-after-frees that also previously blocked Etherpad are fixed and merged in #101 — so GC is no longer a blocker here.
Adherence to the ECO-355 rule
No per-app workarounds / custom fixups:
totaljs-cmsanddashyrun on clean upstream checkouts, and Etherpad's remaining blockers are being fixed at the runtime level (tracked tickets), not patched in the example.🤖 Generated with Claude Code