Flag to require that wrapped object has some finalizer#28
Draft
sadhbh-c0d3 wants to merge 2 commits into
Draft
Conversation
syrusakbary
reviewed
Jun 3, 2026
Co-authored-by: Syrus Akbary <me@syrusakbary.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When guest is calling napi_add_finalizer() it expects valid napi_ref returned and not a nullptr. Correct solution would be to wrap callback and data provided by guest into native finalizer closure. We're not doing this here, and we only set Nop callback to avoid crash that would be caused by returnrf nullptr otherwise.
Note While this fixes the below issue, I have doubts that this should be merged. I think correct solution need to be made for this.
This should fix following crash at startup: