fix: tests: cron job tests

[Jo-Chris]

Bugfix Changelist:

• fixed a bug that reminded THREE_DAYS users every 24 hrs
• fixed a bug that put users who are off for more than 24 hrs (or even 50, 100, or 400 hrs) in the wrong TimeSpan. No matter how long off a user was, if he has never been reminded he always needs to be sorted into the ONE_DAY bucket, otherwise, he does not receive up to 3 notifications.
• fixed lots of false tests
• fixed a bug where users would not have received their final notification, as the last bucket was misconfigured

Test Changelist:

• Added bucket tests for 1 / 3 / 14 days buckets with happy path, edge case and null tests cases
• Updated some edge cases (this is most likely where we will always push more, but the basic logic seems to work now fine)

[wsdt]

sick work @Jo-Chris ! does that mean it is ready now?

[wsdt]

Q: Do we also have test cases for users that:

1. Have been reminded e.g. 2 months ago and now are in ghost mode? Meaning they should be in 24h bucket again

[Jo-Chris]

This Edge case above is only if something is in ghost mode for 2 months and has never been reminded (for whatever reason). Checking the other case you mentioned, good call!

[Jo-Chris]

Q: Do we also have test cases for users that:

1. Have been reminded e.g. 2 months ago and now are in ghost mode? Meaning they should be in 24h bucket again

Well, they shouldn't (currently) - because we do not have a set-back logic. If you've been reminded the last time 2 months ago, that would mean you have received all the 3 notifications back then (from one day to 14 days off) and then the algorithm will not consider you, as you probably removed the app - somewhat (max 3 notifications).

So we'd need to reset the lastDateModeReminderSent to re-start that cycle.

[wsdt]

[Jo-Chris]

Commit 9cebdd0 restarts the cycle without having to reset the lastDateModeReminderSent to null.

Will add 1-2 more tests after lunch, but very confident now.

[wsdt]

Commit 9cebdd0 restarts the cycle without having to reset the lastDateModeReminderSent to null.

Will add 1-2 more tests after lunch, but very confident now.

nice!! sick work Chris. pls let me know once ready to deploy.